No ansible checks to ensure loaded ebtables module

[Miguel Alejandro Cantu]

There are no checks within ansible that check to see if the ebtables module is loaded on the networking hosts.
This will cause the neutron-linuxbridge-agents to fail if the user hasn't already loaded the module on the networking host.

I ran into this problem on Friday when my linuxbridge-agents were logging that ebtables wasn't available on my kernel. I attempted to load the module using modprobe on the neutron agents container, but it failed. The module must be loaded on the networking host, not the container.

[Matthew Thode (prometheanfire)]

what if the module is staticly built into the kernel?

[Jesse Pretorius (jesse-pretorius)]

A fairly simple solution here would be to add ebtables to https://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/defaults/main.yml#L35 - but there are other ways of being more discerning.

[Matthew Thode (prometheanfire)]

Probably easiest to do where jesse said, though that method will eventually need to be fixed to allow for static kernels.

better check would be:

1. zgrep KCONFIG_PARAM /proc/config.gz
2. register output
3.
  a. if output ends in '=y' be happy
  b. if output ends in '=m' do as is being done now
  c. if output ends in 'is not set' fail

[Matthew Thode (prometheanfire)]

might need to be key value based, kconfig and module name

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289622

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290902
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=d9185f72b803daba0c866e63fb21d41792bc4b5f
Submitter: Jenkins
Branch: master

commit d9185f72b803daba0c866e63fb21d41792bc4b5f
Author: Kevin Carter <email address hidden>
Date: Wed Mar 9 17:15:14 2016 -0600

    Add ebtables to openstack_hosts role

    This change adds the ebtables package and kernel module to the
    openstack_host role. This is being added because without it
    the neutron linuxbridge agent will not start in a container
    sighting that the ebtables filter is missing. While we do not
    see this issue in the gate, because its being masked by the os_nova
    role, it is a problem on a multi-node setup when using network nodes
    that are not also compute nodes. With this simple change neutron had
    no issues running in a true multi-node setup.

    Change-Id: Ib178bbeed14c3e6c17613ad72545bcadf66b98cb
    Closes-Bug: 1546818
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: liberty
Review: https://review.openstack.org/291281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291281
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=005e064da52d81518d30a7ef019ba1e93e47e500
Submitter: Jenkins
Branch: liberty

commit 005e064da52d81518d30a7ef019ba1e93e47e500
Author: Kevin Carter <email address hidden>
Date: Thu Mar 10 10:25:28 2016 -0600

    Add ebtables to openstack_hosts role

    This change adds the ebtables package and kernel module to the
    openstack_host role. This is being added because without it
    the neutron linuxbridge agent will not start in a container
    sighting that the ebtables filter is missing. While we do not
    see this issue in the gate, because its being masked by the os_nova
    role, it is a problem on a multi-node setup when using network nodes
    that are not also compute nodes. With this simple change neutron had
    no issues running in a true multi-node setup.

    Change-Id: Ie0cad4efa2d65697a49bbb5da70a59fca85d5fa4
    Backport-of: Ib178bbeed14c3e6c17613ad72545bcadf66b98cb
    Closes-Bug: 1546818
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/291797

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289622
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=0849367b62aa4f37243bb3a90e3b200c0075e572
Submitter: Jenkins
Branch: master

commit 0849367b62aa4f37243bb3a90e3b200c0075e572
Author: Ala Raddaoui <email address hidden>
Date: Mon Mar 7 23:15:27 2016 +0000

    Add ebtables check for network hosts

    Check how ebtables module is configured in
    kernel for network hosts and make sure it is
    loaded.

    Change-Id: I5f0410dfc6cd347920658b74ae0aadf8e4af78b1
    Closes-Bug: 1546818

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 12.0.9 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291797
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=1b6bc3efd9bb37150980c08e68e7fa045f10039d
Submitter: Jenkins
Branch: master

commit 1b6bc3efd9bb37150980c08e68e7fa045f10039d
Author: Ala Raddaoui <email address hidden>
Date: Fri Mar 11 16:03:10 2016 +0000

    Add a check for hosts particular kernel modules

    Some hosts needs to have more specific kernel
    modules loaded in memory. Based on a list of
    those modules and their target group hosts, this
    patch checks how these modules are implemented
    in the kernel by searching for a specified pattern
    for each module in /boot/config-$kernel_version,
    loads them if they are dynamic and fails in case
    they are not set in the kernel configuration.

    Change-Id: I728f36146bd99193b346ebf4158d3716f0fbbed8
    Closes-Bug: 1546818

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/321819

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321819
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=eb1b3afc7414cd25effd29335be7d6cc73c2a0ba
Submitter: Jenkins
Branch: stable/mitaka

commit eb1b3afc7414cd25effd29335be7d6cc73c2a0ba
Author: Ala Raddaoui <email address hidden>
Date: Fri Mar 11 16:03:10 2016 +0000

    Add a check for hosts particular kernel modules

    Some hosts needs to have more specific kernel
    modules loaded in memory. Based on a list of
    those modules and their target group hosts, this
    patch checks how these modules are implemented
    in the kernel by searching for a specified pattern
    for each module in /boot/config-$kernel_version,
    loads them if they are dynamic and fails in case
    they are not set in the kernel configuration.

    Note: This is a manual cherry-pick of
    I728f36146bd99193b346ebf4158d3716f0fbbed8 from master

    Change-Id: I728f36146bd99193b346ebf4158d3716f0fbbed8
    Closes-Bug: 1546818

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 14.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 13.1.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.