Editor: undo/redo doesn't work when placing terrains in one move

Bug #1546810 reported by kaputtnik
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned

Bug Description

- Start Editor
- Select a terrain
- Place the terrain, keep left mouse button down and move over the map
- Do it again with another type of terrain
- Use "undo"

-> Only the first "in one move" placed terrain triangle get removed
-> Clicking undo again removes the first placed triangle of the first move
-> "undo" works only for some steps to such placed terrain
-> "redo" works also only some steps then

Don't know when this comes in, but earlier clicking "redo" removes all terrains which was placed "in one move".

This happens only to terrains. For Immovables it works correct.

Tags: editor ui

Related branches

Revision history for this message
kaputtnik (franku) wrote :

Seems r7764 is the culprit: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/7764

I checked this through reverting and testing. In r7763 it works correct.

Don't know why moving folders has such side effects though.

Changed in widelands:
status: New → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for tracking down the offending commit, that made it very easy to fix :)

Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.