Inconsistent ordering for angular table actions

Bug #1546758 reported by Justin Pomeroy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Justin Pomeroy

Bug Description

The horizon angular actions service uses $qExtensions.allSettled when resolving permitted actions. The allSettled method does not enforce that the order of the pass and fail promise arrays are the same as the original list of promises, and this can cause the order of the actions to be inconsistent. The order of the actions is actually determined by the order in which they are resolved. This causes actions I want to be last in the menu (Delete) to sometimes show up as the default button action.

Justin Pomeroy (jpomero)
Changed in horizon:
assignee: nobody → Justin Pomeroy (jpomero)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/281531

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/281531
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3c31b9b6a33d8785dc306d4a268fad164c1cdde
Submitter: Jenkins
Branch: master

commit e3c31b9b6a33d8785dc306d4a268fad164c1cdde
Author: Justin Pomeroy <email address hidden>
Date: Wed Feb 17 15:14:49 2016 -0600

    Maintain order when resolving promise list

    This updates the $qExtensions.allSettled method so that it maintains
    the order of the original list of promises. The list of passed and
    failed promises will be in the same order as they were in the
    original list.

    Closes-Bug: #1546758
    Change-Id: I9de0b68a16c4f3e2a9a34fb8862de2d77b4a19bb

Changed in horizon:
status: In Progress → Fix Released
Matthias Runge (mrunge)
Changed in horizon:
milestone: none → mitaka-3
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.