run-upgrade script assumes rings are locally held for deployment

Bug #1546225 reported by Bjoern
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Invalid
Undecided
Unassigned
Kilo
Fix Released
Undecided
Bjoern

Bug Description

At https://github.com/openstack/openstack-ansible/blob/kilo/scripts/run-upgrade.sh#L181 we do check for a local swift ring directory which is usually only present on the first swift object node.

Since the upgrade script is executed on the deployment host, the swift rings are not necessarily present on this machine.

Personally I can't find a reason why we even check this in the first place, checking the inventory for actual swift nodes seem sufficient.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/280844

Changed in openstack-ansible:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (kilo)

Reviewed: https://review.openstack.org/280844
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=99217b3aa1dc29fe939a6a9e21bec0407dd6fcd1
Submitter: Jenkins
Branch: kilo

commit 99217b3aa1dc29fe939a6a9e21bec0407dd6fcd1
Author: Bjoern Teipel <email address hidden>
Date: Tue Feb 16 11:39:55 2016 -0600

    Remove local swift ring directory check

    This fix will remove the local check for the swift ring directory.
    Assuming the upgrade script is executed on the deployment host,
    the swift ring files are not necessarily on this host, rather than
    the first swift server.

    Change-Id: Ie1f07a7884b669e2a0c44868711ce76070c8e4bf
    Closes-Bug: #1546225

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.15

This issue was fixed in the openstack/openstack-ansible 11.2.15 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.