Data validation bugs when modifying Data Sources

[Brett]

I've recently finished setting up a brand-new installation of Cacti 0.8.8f+ds1-2 on Ubuntu 15.10 and believe that I've uncovered a data validation bug when modifying data sources. (The same error probably exists elsewhere in the code, but I haven't verified it.) Everything works as expected, except I cannot save any changes to my data source name (for example).

To reproduce the problem, I go to Console -> Data Sources, then pick one of my existing data sources to Edit. (In my case, I selected a Cisco device that's working as expected, is being properly polled by SNMP, and is graphing just fine.) I select an interface such as Gi0/0. Going down to the "Supplemental Data Template Data" section, I tried changing the "Name" field from the default "|host_description| - Traffic - |query_ifIP| - |query_ifName|" to a constant string "Primary ISP" (with no special character, without the quotes, etc.). When I click the SAVE button at the bottom right, I receive red text at the top of the window that reads "Error: Save Failed: Field Input Error (Check Red Fields)." No fields appear in red, and there are no issues with any of the visible data.

If I then leave the screen and come back to it, it appears that my changes have been saved on this screen -- despite the earlier error message! -- but the new information that I entered doesn't appear as expected when I'm looking at the device graphs, device trees, or any other place in the Cacti UI.

I tried something even simpler: open a data source (as above) as if I'm going to edit it, but make no changes at all. When I click SAVE, the error message appears as above.

ProblemType: Bug
DistroRelease: Ubuntu 15.10
Package: cacti 0.8.8f+ds1-2
ProcVersionSignature: Ubuntu 4.2.0-23.28-generic 4.2.6
Uname: Linux 4.2.0-23-generic x86_64
ApportVersion: 2.19.1-0ubuntu5
Architecture: amd64
CurrentDesktop: Unity
Date: Tue Feb 16 10:04:51 2016
InstallationDate: Installed on 2016-01-07 (39 days ago)
InstallationMedia: Ubuntu 15.10 "Wily Werewolf" - Release amd64 (20151021)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: cacti
UpgradeStatus: No upgrade log present (probably fresh install)

[Paul Gevers (paul-climbing)]

Upstream suggests this maybe due to a plugin. Please disable them one by one and report back with the results.

----------------------------------------------------------------------
 (0007173) cigamit (developer) - 2016-06-12 12:23
 http://bugs.cacti.net/view.php?id=2690#c7173
----------------------------------------------------------------------
Paul, I can not reproduce in 0.8.8g for sure. Will test 0.8.8h shortly,
but I suspect the same.

----------------------------------------------------------------------
 (0007174) cigamit (developer) - 2016-06-12 12:27
 http://bugs.cacti.net/view.php?id=2690#c7174
----------------------------------------------------------------------
Confirming same in 0.8.8h. Likely a plugin that is hooking the environment
and generating the error. Have the user disable plugins one at a time. If
we don't hear back for a week, we will assume that this is resolved.

[Brett (bkessler)]

I have not installed any plugins, so I'm not sure what plugins should be disabled.

[Brett (bkessler)]

Attached is a screenshot showing that I have no plugins.