OpenStack Dashboard (Horizon)

Missing backdrop on "Add Group Assignment" modal

Bug #1545892 reported by Alan Fung on 2016-02-16

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Low	Alan Fung	OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

All if not most modal have semi-opaque backdrops. The Add-Group-Assignment modal does not have one.

Reproduce:
1. Go to Identity > Groups.
2. Click click "Manage Members" for any particular group from the table.
3. Click on "Add Users".

Expected:
Has a semi-opaque backdrop behind the modal.

Actual:
Has no semi-opaque backdrop behind the modal.

Tags:

Alan Fung (alanfung) on 2016-02-16

Changed in horizon:
assignee:	nobody → Alan Fung (alanfung)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-02-16: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280472

Changed in horizon:
status:	New → In Progress

Revision history for this message

Alan Fung (alanfung) wrote on 2016-02-16:

Screen Shot 2016-02-15 at 4.27.15 PM.png Edit (228.7 KiB, image/png)

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-03-21

Changed in horizon:
importance:	Undecided → Low
milestone:	none → newton-1

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-05-16

tags:

added: mitaka-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/280472
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f195fea9390f7650c372b3e749c1ad0342e72036
Submitter: Jenkins
Branch: master

commit f195fea9390f7650c372b3e749c1ad0342e72036
Author: Alan Fung <email address hidden>
Date: Mon Feb 15 18:01:13 2016 -0800

Fix issue with some modals are missing backdrop

    Some modal views are inheriting from ModalFormMixin directly instead of
    from ModalFormView (i.e. NonMembersView). This causes inconsistency with
    some modal does not have a backdrop (not inheriting ModalBackdropMixin).
    There are 7 places that inherit from ModalFormView directly now, and
    they appear to be needing a backdrop; it'd be logical that
    ModalFormMixin inherit from ModalBackdropMixin.

Change-Id: Id878a82341c8e84d5c0ca798aa648a8e7940df0e
Closes-Bug: #1545892

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-31: Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323356

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-06-02: Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-31: Fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/323356
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=68d22660bb526eab6174bda01d38a8dc40eaf042
Submitter: Jenkins
Branch: stable/mitaka

commit 68d22660bb526eab6174bda01d38a8dc40eaf042
Author: Alan Fung <email address hidden>
Date: Mon Feb 15 18:01:13 2016 -0800

Fix issue with some modals are missing backdrop

    Change-Id: Id878a82341c8e84d5c0ca798aa648a8e7940df0e
    Closes-Bug: #1545892
    (cherry picked from commit f195fea9390f7650c372b3e749c1ad0342e72036)