A close icon in the upper right don't show in Update Metadata

Bug #1545655 reported by Kenji Ishii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Kenji Ishii

Bug Description

A close icon in the upper right can close modal dialog.
Other modal dialog have this icon but Update Metadata dialog don't have it.
When we use a browser with not maximize window, it often needs a scroll operation.
Therefore it is better to add icon in the upper right to cancel the modal, same as other modals.

Kenji Ishii (ken-ishii)
Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280133

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/280133
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=de30e3c7d3c6ac1287bfd88af7abc58d13c1c1d9
Submitter: Jenkins
Branch: master

commit de30e3c7d3c6ac1287bfd88af7abc58d13c1c1d9
Author: Kenji Ishii <email address hidden>
Date: Mon Feb 15 19:10:04 2016 +0900

    Add a close icon in the upper right in Update Metadata modal

    Other modal dialog have this icon but Update Metadata dialog
    don't have it. This patch will fix it.

    Change-Id: I6f7bc243d3ef5e48fc68fbd0000fa1dcc39b51df
    Closes-Bug: #1545655

Changed in horizon:
status: In Progress → Fix Released
Matthias Runge (mrunge)
Changed in horizon:
milestone: none → mitaka-3
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.