Cannot create remote_mac_entry with same vtep_address

[Kengo Hobo]

Cannot create remote_mac_entry with same vtep_address.

When there are more than one site-to-site connection because of multi-tenant in site,
there are multiple peer-router in site.
This means that multiple peer-router exists under the same VTEP.
So we should remove uniqueness validation for vtep_address in remote_mac_entry so that we can provide site-to-site connection with multi-tenancy.

Error is following.
*GET remote_mac_entries
ubuntu@instance16:~$ curl -si -X GET -H "Content-type: application/json" http://172.16.1.17:9696/v2.0/gw/gateway_devices/71e9fcf4-e5f1-48a1-953e-fe6325a8635d/remote_mac_entries -H "X-AUTH-TOKEN:${TOKEN}"
HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Content-Length: 294
X-Openstack-Request-Id: req-e90c210b-e97b-4c8d-bbeb-da89ef8cb1a4
Date: Mon, 15 Feb 2016 04:01:19 GMT

{"remote_mac_entries": [{"segmentation_id": 100, "vtep_address": "1.1.1.2", "id": "5550247a-fd87-4f2a-b300-c659c744bfde", "mac_address": "aa:aa:aa:aa:aa:ab"}, {"segmentation_id": 100, "vtep_address": "1.1.1.1", "id": "62b9021d-2e15-4aff-9d42-e01cafb34c81", "mac_address": "aa:aa:aa:aa:aa:aa"}]}

*POST remote_mac_entry with same vtep_address
ubuntu@instance16:~$ curl -si -X POST -H "Content-type: application/json" http://172.16.1.17:9696/v2.0/gw/gateway_devices/71e9fcf4-e5f1-48a1-953e-fe6325a8635d/remote_mac_entries -H "X-AUTH-TOKEN:${TOKEN}" -d '{"remote_mac_entry": {"segmentation_id": 100, "vtep_address": "1.1.1.2", "mac_address": "aa:aa:aa:aa:aa:ac"}}'
HTTP/1.1 409 Conflict
Content-Type: application/json; charset=UTF-8
Content-Length: 186
X-Openstack-Request-Id: req-6874df8d-ff9c-406a-ac6b-e871847be052
Date: Mon, 15 Feb 2016 03:52:11 GMT

{"NeutronError": {"message": "Request contains duplicate remote mac address entry: mac_address aa:aa:aa:aa:aa:ac vtep_address 1.1.1.2.", "type": "DuplicateRemoteMacEntry", "detail": ""}}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/280148

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280148
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=fa853b575ba8e41cae5d2d4d7cc85d9ba8894ff2
Submitter: Jenkins
Branch: master

commit fa853b575ba8e41cae5d2d4d7cc85d9ba8894ff2
Author: Kengo Hobo <email address hidden>
Date: Mon Feb 15 10:43:50 2016 +0000

    Remove uniqueness validation for vtep_address in remote_mac_entry.

    This patch removes uniqueness validation for vtep_address in remote_mac_entry
    to allow deploying multiple router under single VTEP router.

    Change-Id: Iacb973b5d5cd186f66f1d8b672e48fbf813df3a4
    Closes-Bug: #1545571