LTSP5

libpam-sshauth: compiler warnings

Bug #1545393 reported by Vagrant Cascadian on 2016-02-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	LTSP5	Fix Released	Undecided	Unassigned

Bug Description

When compiling libpam-sshauth's current bzr branch with debian
sid/unstable toolchain, I get the following compiler warnings:

gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -fpic -Wall -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o pam_sshauth_so-auth_funcs.o `test -f 'auth_funcs.c' || echo './'`auth_funcs.c
auth_funcs.c:40:0: warning: "SSH_AUTH_METHOD_PUBLICKEY" redefined
#define SSH_AUTH_METHOD_PUBLICKEY 3
^
In file included from auth_funcs.c:36:0:
pam_sshauth.h:30:0: note: this is the location of the previous definition
#define SSH_AUTH_METHOD_PUBLICKEY 4
^

This can presumably be fixed by dropping one of the defines, but I'm
not sure which would be best to drop.

gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -fpic -Wall -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o pam_sshauth_so-sess_funcs.o `test -f 'sess_funcs.c' || echo './'`sess_funcs.c
sess_funcs.c: In function 'askpass_create':
sess_funcs.c:99:3: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
write (f, password, strlen (password));
^

Not sure what to do there.

Will test the build soon.

live well,
vagrant