pcb

PIns/Via show Name/Number menu item doesn't work, only D hotkey does

Bug #1545165 reported by Britton Kerin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Low
Unassigned

Bug Description

Activating the menu item doesn't do anything under gtk at least. It doesn't act on the selected item or items, and it doesn't put pcb in its "expect-an-item-to-be-selected" state.

The d hotkey does work. In practice using this via the menu is so cumbersome that probably nobody does it, but its confusing to have the menu item broken this way.

I would probably "fix" this by just making the menu item pop up an info dialog telling the user to use the hot key instead.

Tags: gtk-gui
Revision history for this message
Nicklas Karlsson (nicklas-karlsson17) wrote :

I could confirm this bug.

Changed in pcb:
status: New → Confirmed
importance: Undecided → Low
milestone: none → next-bug-release
tags: added: gtk-gui
Revision history for this message
Nicklas Karlsson (nicklas-karlsson17) wrote :

Good solution is probably to remove cross hair then exiting active drawing area.

Revision history for this message
Nicklas Karlsson (nicklas-karlsson17) wrote :

In GTK there is a "focus-out-event", then starting pcb with pointer outside drawing area cross hair end up at coordinate zero.

Revision history for this message
Nicklas Karlsson (nicklas-karlsson17) wrote :

Solution is probably to to figure out how pcb keep track of pointer coordinate validity and invalidate.

In file "gui_act.c" the following code is executed:
  notify_mark_change(false);
  Marked.status = false;
  notify_mark_change(true);

The code probably invalidate the coordinate and to invalidate the coordinate from "focus-out-event" might be the solution.

Revision history for this message
Chad Parker (parker-charles) wrote :

Just a note here: Bert committed a fix for this bug into master on 2016-04-24. The fix prompts the user to select an element.

Changed in pcb:
milestone: next-bug-release → future-bug-release
Changed in pcb:
status: Confirmed → Fix Committed
Changed in pcb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.