Using scope to clear table selections

Bug #1544835 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Thai Tran

Bug Description

We currently use scope to clear table selections. This is not ideal because it breaks encapsulation and encourages the use of scope over ctrl. We should provide a method that can clear instead.

Reference: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images.controller.js#L101

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/279383

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/279383
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c28b8267de69d099c8a97f6bb5b796208c5575ca
Submitter: Jenkins
Branch: master

commit c28b8267de69d099c8a97f6bb5b796208c5575ca
Author: Thai Tran <email address hidden>
Date: Wed Feb 17 11:01:42 2016 -0800

    Using events to clear table selections instead of scope

    We currently use scope to clear table selections. This is not ideal because it
    breaks encapsulation and encourages the use of scope over ctrl. This patch
    adds a clear method and uses event propagation to invoke it.

    Change-Id: I6115047298d5fa673eabb707a358c84a4e6d9eb6
    Closes-Bug: #1544835

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.