Audit prop/header names for matching style

Bug #1544584 reported by Brian Curtin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack SDK
Fix Released
Critical
Richard Theis

Bug Description

While reviewing an issue I noticed that several bool named props in Identity v2 and v3 such as "enabled". Due to the confusion sometimes seen between a name that appears as either a bool or a timestamp, e.g., "updated" in some places is a bool whether the thing has been updated and in some places it's a timestamp of when the thing was updated, we've been generally using a different scheme for those names.

bools are prefixed with "is_", so is_updated, is_enabled, etc.
timestamps are suffixed with "_at", so updated_at, enabled_at

Table to track overall progress by component
    [Done] block_store - https://review.openstack.org/#/c/289581/
    [Done] cluster - https://review.openstack.org/#/c/298263/
    [Done] compute - https://review.openstack.org/#/c/291766/
    [No changes] database
    [Done] identity - https://review.openstack.org/#/c/295392/
    [Done] image - https://review.openstack.org/#/c/292495/
    [Done] key_manager - https://review.openstack.org/#/c/293082/
    [No changes] message
    [Done] metric - https://review.openstack.org/#/c/289532/
    [Done] network - https://review.openstack.org/#/c/297235/
    [Done] object_store - https://review.openstack.org/#/c/297828/
    [Done] orchestration - https://review.openstack.org/#/c/294766/
    [Done] telemetry - https://review.openstack.org/#/c/294604/

Richard Theis (rtheis)
Changed in python-openstacksdk:
assignee: nobody → Richard Theis (rtheis)
Richard Theis (rtheis)
description: updated
Richard Theis (rtheis)
description: updated
Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/289532

Changed in python-openstacksdk:
status: Confirmed → In Progress
Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/289532
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=45a9cab6534a84a2e7c3f97f5ee965892473ec00
Submitter: Jenkins
Branch: master

commit 45a9cab6534a84a2e7c3f97f5ee965892473ec00
Author: Richard Theis <email address hidden>
Date: Mon Mar 7 13:27:35 2016 -0600

    Consistent resource.prop for timestamps and booleans (metric)

    This patch set updates all metric objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes

    Change-Id: Icd5b55eb072dc68935b5378db7ec0965f3b06e73
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/289581

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/289581
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=f56914116400e4f367a5e9305025c02c1e5893b2
Submitter: Jenkins
Branch: master

commit f56914116400e4f367a5e9305025c02c1e5893b2
Author: Richard Theis <email address hidden>
Date: Mon Mar 7 14:25:40 2016 -0600

    Consistent resource.prop for timestamps and booleans (block store)

    This patch set updates all block store objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: I5b37f669d8ac96e76f1c7da718bd863148d86d4b
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291766

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/291766
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=94d637cfcd62a5e07ad90107802fd8b668776840
Submitter: Jenkins
Branch: master

commit 94d637cfcd62a5e07ad90107802fd8b668776840
Author: Richard Theis <email address hidden>
Date: Fri Mar 11 09:00:35 2016 -0600

    Consistent resource.prop for timestamps and booleans (compute)

    This patch set updates all compute objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: I6dbb946dad0d9daee5fd766fab6577e9701edb35
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292495

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/292495
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=17e328141dc4568da5157eb771d2c9fde4e6a8d0
Submitter: Jenkins
Branch: master

commit 17e328141dc4568da5157eb771d2c9fde4e6a8d0
Author: Richard Theis <email address hidden>
Date: Mon Mar 14 10:57:14 2016 -0500

    Consistent resource.prop for timestamps and booleans (image)

    This patch set updates all image objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: Iba0751c74bd1a05f687fceed2ca3c8b7167a44c8
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/293082

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/293082
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=e75ec309476df1f00889df45513061b1e2223d0a
Submitter: Jenkins
Branch: master

commit e75ec309476df1f00889df45513061b1e2223d0a
Author: Richard Theis <email address hidden>
Date: Tue Mar 15 13:13:57 2016 -0500

    Consistent resource.prop for timestamps and booleans (key manager)

    This patch set updates all key manager objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: I512f5a72a6cc3edbaeaa48b8e3677a0db9da68e9
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294604

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/294604
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=381e9ab197d48be86fe8d153ec3245d5ffbc726c
Submitter: Jenkins
Branch: master

commit 381e9ab197d48be86fe8d153ec3245d5ffbc726c
Author: Richard Theis <email address hidden>
Date: Fri Mar 18 08:54:55 2016 -0500

    Consistent resource.prop for timestamps and booleans (telemetry)

    This patch set updates all telemetry objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: I76e98a0f929b8688685a7e9de2d362d8a0a1b555
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294766

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/295392

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/295392
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=1d9958e926e27cc16d3319d9b58a52a49ee11142
Submitter: Jenkins
Branch: master

commit 1d9958e926e27cc16d3319d9b58a52a49ee11142
Author: Richard Theis <email address hidden>
Date: Mon Mar 21 11:31:49 2016 -0500

    Consistent resource.prop for timestamps and booleans (identity)

    This patch set updates all identity objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: Iad86a67b4998c894b80f5f401890ec97995e71f8
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/294766
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=680163193353c466c24748f3c8a829872b5a7cc6
Submitter: Jenkins
Branch: master

commit 680163193353c466c24748f3c8a829872b5a7cc6
Author: Richard Theis <email address hidden>
Date: Fri Mar 18 13:51:45 2016 -0500

    Consistent resource.prop for timestamps and booleans (orchestration)

    This patch set updates all orchestration objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: Ic84a481a25e845ad3e05ffeefb55d56371b571bc
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/297235

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/297828

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/298263

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/297828
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=b4329508e9e5e860a1847dfcecb34cc9ec96861b
Submitter: Jenkins
Branch: master

commit b4329508e9e5e860a1847dfcecb34cc9ec96861b
Author: Richard Theis <email address hidden>
Date: Fri Mar 25 12:52:51 2016 -0500

    Consistent resource.prop for timestamps and booleans (object store)

    This patch set updates all object store objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    This patch set also include missing documentation for the
    Account resource.

    Change-Id: Ibf204bb0ab444e7090c1102acdd3d0e1d9722829
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/297235
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=f27594350ba6249a70631eeb1080ae39d58d3c79
Submitter: Jenkins
Branch: master

commit f27594350ba6249a70631eeb1080ae39d58d3c79
Author: Richard Theis <email address hidden>
Date: Wed Mar 23 15:20:13 2016 -0500

    Consistent resource.prop for timestamps and booleans (network)

    This patch set updates all network objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes
      - Maintian alphabetical order of property names

    This patch also removes the 'router_type' attribute from the
    Network resource since it isn't a core network extension and
    conflicts with the existing boolean.

    Change-Id: I118b159f245fd76337e4c56b9918ffa411fc8a90
    Partial-Bug: #1544584

Richard Theis (rtheis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/298263
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=985e66a8debdfc3bb6ce9f3157c166c739ec9e62
Submitter: Jenkins
Branch: master

commit 985e66a8debdfc3bb6ce9f3157c166c739ec9e62
Author: Richard Theis <email address hidden>
Date: Fri Mar 25 15:40:28 2016 -0500

    Consistent resource.prop for timestamps and booleans (cluster)

    This patch set updates all cluster objects to use consistent
    resource.prop for timestamps and booleans. In particular, the
    following changes were made:
      - Clarify documentation for timestamp and boolean attributes
      - Use 'is_' prefix and boolean type for boolean attributes
      - Use '_at' suffix and timestamp type for timestamp attributes

    Change-Id: Ie08fcddf47643fabb2bacdc74bc1c582b1598fb9
    Partial-Bug: #1544584

Revision history for this message
Richard Theis (rtheis) wrote :

All fixes have been merged.

description: updated
Changed in python-openstacksdk:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.