AttributeError: 'NoneType' object has no attribute 'service_types'

[Emilien Macchi]

A recent commit in Heat broke Puppet OpenStack & RDO packaging CI:
https://github.com/openstack/heat/commit/547e0c339d6041f02169efbd2e55520e1000e240

Heat API logs: https://ci.centos.org/artifacts/rdo/weirdo-promote-mitaka-puppet-openstack-scenario002/73/puppet-openstack/logs/heat/heat-api.txt.gz

See: AttributeError: 'NoneType' object has no attribute 'service_types'

The CI was running fine before this commit, so we need to change something in configuration because of this?

Please look at logs & config files here:
https://ci.centos.org/artifacts/rdo/weirdo-promote-mitaka-puppet-openstack-scenario002/73/puppet-openstack/logs/

Thanks

[David Moreau Simard (dmsimard)]

We caught this when running tempest for the heat smoke tests, output available here: http://paste.openstack.org/raw/486485/

[Emilien Macchi (emilienm)]

We think it's rather a new patch in tempest, that is causing this issue. Adding the project FYI, feel free to invalidate them.
https://github.com/openstack/tempest/commit/aa461b746bac5144d99454ebdfece860e3fd7173

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278068

[Thomas Herve (therve)]

There are maybe 2 different issues. We run those tests in upstream Heat, so it's likely to be a difference in the way the run are setup.

The first one is most likely due to the fact that clients are missing. This is something we should handle though, and I believe there is an easy fix.

The second one is bit weirder (about the role missing). I suppose you're not using devstack to setup the node, so there ought to be something that changed in the way Heat needs to be configured WRT roles. I don't think we need to change something in Heat for this one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278081

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278239

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rabi Mishra (<email address hidden>) on branch: master
Review: https://review.openstack.org/278239

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/278081
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=76f99a9036c10b5ae88a92d826bb12d6f6945844
Submitter: Jenkins
Branch: master

commit 76f99a9036c10b5ae88a92d826bb12d6f6945844
Author: Thomas Herve <email address hidden>
Date: Tue Feb 9 21:35:19 2016 +0100

    Handle missing plugin in is_service_available

    When a client is not installed, Heat should behave as if the service was
    unavailable. We recently started exposing exceptions when checking for
    service availability, which displayed that it fails if the client plugin
    returs None. Let's test and handle that case.

    Change-Id: I71d5fd5be2efd7734d8569e4d26ab1b512453343
    Closes-Bug: #1543759

[David Moreau Simard (dmsimard)]

Thomas, your patch and the tempest revert fixed some errors but we are still hitting one, see: http://logs.openstack.org/20/278520/1/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7/6f82bf6/logs/heat/heat-engine.txt.gz#_2016-02-10_17_54_16_906

The tempest test failure is here: http://logs.openstack.org/20/278520/1/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7/6f82bf6/console.html#_2016-02-10_17_56_41_885

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.

[Ken'ichi Ohmichi (oomichi)]

Tempest side also has been reverted back with https://review.openstack.org/#/c/278068/
So I mark this as Fix on Tempest side.