Angular controllers (routes being evaluated) on django navbar clicks (hash routing)

[Travis Tripp]

While evaluating another patch, I found that if I'm on an angular page (ng-images) that whenever I click an accordion on the horizon navbar (e.g. start on Project --> Images, then click Admin) this is causing the current angular controller to refresh.

See picture, but note that I have paused the debugger in a Keystone API hit, that you can see the requests in the terminal window, and that in the URL you can see #sidebar-accordion-admin.

http://pasteboard.co/1pw530qO.png

[Rob Cresswell (robcresswell-deactivatedaccount)]

This actually appears to alter the URL on all pages, not just angular ones.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Looking into this more, seems like it hits the APIs with a full reload every time.

[Richard Jones (r1chardj0n3s)]

Rob, could you be clearer what you mean by a "full reload"? I'm not seeing that, I think.

I'm certainly not seeing what Travis described as "causing the current angular controller to refresh." When I'm on the Swift UI page, for example, and click out to Images, the Swift page does not refresh, we go to the Images page and it's loaded as per normal (I see an images load and a projects load, which I'd expect to see on a Django page load - definitely none of the Swift controller loading API hits).

[Rob Cresswell (robcresswell-deactivatedaccount)]

Try opening a panel group or dashboard, not a panel and watch the APIs on your swift endpoint. For me, it seemed to be causing a reload. This means that if someone is just looking for something, they'll be spamming the APIs.

[Richard Jones (r1chardj0n3s)]

Ah, I see what you mean now.

[Richard Jones (r1chardj0n3s)]

I *think* the appropriate thing to do would be to have the sidebar call event.stopPropagation().

[Wang Bo (chestack)]

Run into the same issue.
Find that the url "project/ngimages/#sidebar-accordion-****" hits the route url[1] which resulted in reload. Should we use "data-target" instead of "href"?[2].
The patch is: https://review.openstack.org/#/c/317293/.

[1]https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/images.module.js#L190.
[2]https://github.com/openstack/xstatic-bootstrap-scss/blob/master/xstatic/pkg/bootstrap_scss/data/js/bootstrap.js#L505

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317293
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=18b351b9c47f180118b10dcf3229e6265c811493
Submitter: Jenkins
Branch: master

commit 18b351b9c47f180118b10dcf3229e6265c811493
Author: wangbo <[e-mail]>
Date: Tue May 17 15:12:40 2016 +0800

    Angular pages will reload if collapse/expand sidebar

    use ng-images as example to explan the issue:
    1.enable ng-images page and go into this page.
    2.click left sidebar to collapse/expand a dashboard or panel-group
    3.the url change to "project/ngimages/#sidebar-accordion-***" which
      match the route[1]. Current page will reload even it's not change.

    Use "data-target" instead of "href" to fix it. ref:[2]

    [1]https://github.com/openstack/horizon/blob/master/
    openstack_dashboard/static/app/core/images/images.module.js#L190
    [2]https://github.com/openstack/xstatic-bootstrap-scss/blob/
    master/xstatic/pkg/bootstrap_scss/data/js/bootstrap.js#L505

    Change-Id: I1c84c6af49a67bf2833ad5b0103f6cbd4abd0ddb
    Closes-Bug: #1543327

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.