Prevent user to remove last location of the image
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Low
|
Brian Rosmaita |
Bug Description
https:/
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/glance" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.
commit c5c731c7153d6d4
Author: Erno Kuvaja <email address hidden>
Date: Tue Jan 19 13:37:05 2016 +0000
Prevent user to remove last location of the image
If the last location of the image is removed, image transitions back to queued.
This allows user to upload new data into the existing image record. By
preventing removal of the last location we prevent the image transition back to
queued.
This change also prevents doing the same operation via replacing the locations
with empty list.
SecurityImpact
DocImpact
APIImpact
Conflicts:
glance/
Conflicts:
glance/
Change-Id: Ieb03aaba887492
Closes-Bug: #1525915
(cherry picked from commit e9e45baa9aaf58e
Changed in glance: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Brian Rosmaita (brian-rosmaita) |
Changed in glance: | |
importance: | Medium → Low |
This was fixed in Mitaka (doc'd with a release note) and I think backported to kilo and liberty.
Release note says:
Fixing bug 1525915; image might be transitioning
from active to queued by regular user by removing
last location of image (or replacing locations
with empty list). This allows user to re-upload
data to the image breaking Glance's promise of
image data immutability. From now on, last
location cannot be removed and locations cannot
be replaced with empty list.
* Update the PATCH call in the api-ref to mention this. Maybe have a brief section of "stuff that could cause your call to fail"? (Check to see whether the default is only an admin can update locations -- I think it is.)