Consolidate names in bob worker programs
Bug #1542705 reported by
SirVer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
From: https:/
How about we add some more consistency in worker/production program names? e.g. we have:
check_soldier
playFX
create_bob
geologist-find
The underscores are most common, so I am in favour of renaming
playFX -> play_sound
geologist-find -> geologist_find
This might affect savegame compatibility, so it needs to happen before b19.
Related branches
lp:~widelands-dev/widelands/bug-1542705
- TiborB: Approve
-
Diff: 1187 lines (+143/-144)47 files modifieddata/tribes/buildings/productionsites/atlanteans/horsefarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/atlanteans/sawmill/init.lua (+1/-1)
data/tribes/buildings/productionsites/atlanteans/weaponsmithy/init.lua (+10/-10)
data/tribes/buildings/productionsites/barbarians/ax_workshop/init.lua (+6/-6)
data/tribes/buildings/productionsites/barbarians/cattlefarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/barbarians/metal_workshop/init.lua (+10/-10)
data/tribes/buildings/productionsites/barbarians/warmill/init.lua (+12/-12)
data/tribes/buildings/productionsites/empire/donkeyfarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/mill/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/piggery/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/sawmill/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/sheepfarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/stonemasons_house/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/toolsmithy/init.lua (+12/-12)
data/tribes/buildings/productionsites/empire/weaponsmithy/init.lua (+10/-10)
data/tribes/workers/atlanteans/farmer/init.lua (+1/-1)
data/tribes/workers/atlanteans/fisher/init.lua (+2/-2)
data/tribes/workers/atlanteans/geologist/init.lua (+2/-2)
data/tribes/workers/atlanteans/shipwright/init.lua (+1/-1)
data/tribes/workers/atlanteans/stonecutter/init.lua (+1/-1)
data/tribes/workers/atlanteans/woodcutter/init.lua (+1/-1)
data/tribes/workers/barbarians/farmer/init.lua (+1/-1)
data/tribes/workers/barbarians/fisher/init.lua (+2/-2)
data/tribes/workers/barbarians/geologist/init.lua (+2/-2)
data/tribes/workers/barbarians/lumberjack/init.lua (+2/-2)
data/tribes/workers/barbarians/shipwright/init.lua (+1/-1)
data/tribes/workers/barbarians/stonemason/init.lua (+1/-1)
data/tribes/workers/empire/farmer/init.lua (+1/-1)
data/tribes/workers/empire/fisher/init.lua (+2/-2)
data/tribes/workers/empire/geologist/init.lua (+2/-2)
data/tribes/workers/empire/lumberjack/init.lua (+2/-2)
data/tribes/workers/empire/shipwright/init.lua (+1/-1)
data/tribes/workers/empire/stonemason/init.lua (+2/-2)
doc/sphinx/source/productionsite_program.rst (+2/-2)
src/graphic/animation.cc (+3/-3)
src/graphic/animation.h (+1/-1)
src/graphic/rendertarget.cc (+2/-2)
src/logic/map_objects/immovable.cc (+5/-5)
src/logic/map_objects/immovable_program.h (+9/-10)
src/logic/map_objects/tribes/production_program.cc (+5/-5)
src/logic/map_objects/tribes/production_program.h (+9/-9)
src/logic/map_objects/tribes/productionsite.h (+1/-1)
src/logic/map_objects/tribes/worker.cc (+1/-1)
src/logic/map_objects/tribes/worker.h (+1/-1)
src/logic/map_objects/tribes/worker_program.cc (+6/-6)
src/logic/map_objects/tribes/worker_program.h (+1/-1)
src/sound/sound_handler.h (+1/-1)
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| summary: |
- Consolidate names in bob workes programs + Consolidate names in bob worker programs |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
To post a comment you must log in.
Fixed in build19-rc1.