Need to include 'metadata' in Cinder's VolumeSnapshot object in Horizon API

[Vivek Agrawal]

The VolumeSnapshot object in 'horizon/openstack_dashboard/api/cinder.py'. This object is accessed by multiple views in Horizon. The object does not have metadata populated for the snapshot.

[Vivek Agrawal (vivek-agrawal)]

In case I am extending horizon functionality and have stored some metadata information for snapshot_metadata. Then the key values of metadata are not accessible to Horizon through the VolumeSnapshots object of cinder.py in horizon API. If we have a list of snapshots then we need to iterate and get snapshot metadata separately which is not a good idea. This functionality was present in earlier release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279667

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281629

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/281629
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279667
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a05883d88a22042a795e48e167c3e2c746f2c89d
Submitter: Jenkins
Branch: master

commit a05883d88a22042a795e48e167c3e2c746f2c89d
Author: Vivek Agrawal <email address hidden>
Date: Thu Feb 11 13:34:52 2016 -0800

    Addition of metadata for snapshot in VolumeSnapshot object

    When accessing the snapshot object in Horizon codebase, we do not have
    access to the metadata of the snapshot. This is because the
    VolumeSnapshot object does not have metadata as a member. So added
    'metadata' to the VolumeSnapshot object. The fix should provide access
    to metadata.
    Added test data and test cases for snapshot object with metadata.

    Closes-Bug: 1542468

    Change-Id: I4ae2e7a74d3ddbff8493b42f8f86c7002229cf8c

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.