[Mainline-Build 2704]: Fat flow- For intra compute UDP traffic, icmp error response for the corresponding Fat flow is in HOLD state

[alok kumar]

consider the below case:
VM DNS server 2002:1::5 has Fat configuration for UDP port 53.
VM 2002:1::3 (both VMs on same node) does nslookup to 2002:1::5 where DNS port 53 is not reachable for some reason.

DNS VM will send port not reachable icmp error for the DNS query, but this error response is marked HOLD in the flow and never reaches the destination.

root@nodec12:~# flow -l|grep 2002:1::5 -A2 -B2|grep 2002:1::3 -A2 -B2
-----------------------------------------------------------------------------------
    51400<=>276056 2002:1::3:40726 17 (7)
                         2002:1::5:53
    (K(nh):43, Action:F, Flags:, S(nh):43, Statistics:1/90 UdpSrcPort 56287

    77736 2002:1::5:53 17 (7)
                         2002:1::3:0
    (K(nh):28, Action:H, Flags:, S(nh):0, Statistics:1/138 UdpSrcPort 0
--
--

   276056<=>51400 2002:1::5:53 17 (7)
                         2002:1::3:40726
    (K(nh):28, Action:F, Flags:, S(nh):28, Statistics:0/0 UdpSrcPort 55097

[alok kumar (kalok)]

This was not seen in mainline 2711 but I again see this issue on R3.0 2717.
This is only for IPv6.

root@nodec12:~# flow -l| grep 2002:1::5 -A2 -B2 | grep 2002:1::6 -A2 -B2

   485300 2002:1::6:53 17 (1)
                         2002:1::5:0
(Gen: 1, K(nh):33, Action:H, Flags:, S(nh):0, Stats:1/139, SPort 0)
--
--

   884664<=>1184504 2002:1::6:53 17 (1)
                         2002:1::5:55175
(Gen: 1, K(nh):33, Action:F, Flags:, S(nh):33, Stats:0/0, SPort 60067)
--

  1184504<=>884664 2002:1::5:55175 17 (1)
                         2002:1::6:53
(Gen: 1, K(nh):40, Action:F, Flags:, S(nh):40, Stats:1/91, SPort 51695)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17897
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17897
Committed: http://github.org/Juniper/contrail-controller/commit/d5fb908e986f3804025294a672889ac474b12f3e
Submitter: Zuul
Branch: R3.0

commit d5fb908e986f3804025294a672889ac474b12f3e
Author: Naveen N <email address hidden>
Date: Fri Feb 26 14:22:43 2016 +0530

* In case of IPv6 ICMP errors parse thru inner payload
and frame the flow key.
Closes-bug:#1542207

Change-Id: I66793922b0bba02c43c9eebde86bafa7e8035e9e

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18110
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18110
Committed: http://github.org/Juniper/contrail-controller/commit/2789e04d0eb336e25e4e69ef61701af320249bcd
Submitter: Zuul
Branch: master

commit 2789e04d0eb336e25e4e69ef61701af320249bcd
Author: Naveen N <email address hidden>
Date: Fri Feb 26 14:22:43 2016 +0530

* In case of IPv6 ICMP errors parse thru inner payload
and frame the flow key.
Closes-bug:#1542207

Change-Id: I66793922b0bba02c43c9eebde86bafa7e8035e9e

Fix Agent UT failures

Fix failures in test_pkt_flowv6 and test_sg_flowv6
For ICMPv6 protocol set the ICMP type as ECHO_REQUEST and
lookup of ICMPv6 flows should be done with destination port
as ECHO_REPLY

(cherry picked from commit 4e6f8c92e80ab0a69dcd8ef710a77fbf7372d152)
Closes-Bug: #1550727
Change-Id: I89c2137fcaac812bcfb517c7c3aa531b2fed5421

[alok kumar (kalok)]

covered in test case test_fat_flow_icmp_error.