BGPaaS: unsetting bgpaas IP address deletes bgp client router

[amit surana]

Unsetting the IP address on the bgpaas object, results in the bhp-client router getting deleted. bgpaas object still holds a ref to the old bhp-client router, but the fqdn is marked 'ERROR'.

[Sachin Bansal (sbansal)]

When we update a BgpAsAService object from ui, it is updating all fields including bgp-router-refs. Also, it sends vmi refs to empty first, then sets it to the old value again later. This interferes with schema transformer updating bgp-router-refs. Please see the logs below that were seen when we created the object with a vmi, then added an ip address:

2016 Feb 08 17:54:08.378434 csol1-node3 [:contrail-api:] : VncApiConfigLog: [VncApiCommon: object_type = bgp_as_a_service, identifier_name = default-domain:bgp-test:bgpaas-3, url = http://172.16.80.3:9100/bgp-as-a-services, operation = post, useragent = Restler for node.js, remote_ip = 172.16.80.3:9100, body = {"bgp-as-a-service": {"bgpaas_session_attributes": {"auth_data": null, "admin_down": false, "loop_count": 0, "passive": true, "family_attributes": [{"prefix_limit": {"maximum": 0}, "loop_count": 0, "address_family": "inet"}, {"prefix_limit": {"maximum": 0}, "loop_count": 0, "address_family": "inet6"}], "hold_time": 0, "address_families": {"family": ["inet", "inet6"]}}, "fq_name": ["default-domain", "bgp-test", "bgpaas-3"], "name": "bgpaas-3", "parent_type": "project", "virtual_machine_interface_refs": [{"to": ["default-domain", "bgp-test", "p0"], "uuid": "347feb2e-82b3-4156-8bf5-91d50414c45b"}], "perms2": {"owner": null, "owner_access": 7, "global_access": 0, "share": []}, "id_perms": {"enable": true, "uuid": null, "creator": null, "created": 0, "user_visible": true, "last_modified": 0, "permissions": {"owner": "cloud-admin", "owner_access": 7, "other_access": 7, "group": "cloud-admin-group", "group_access": 7}, "description": null}, "display_name": "bgpaas-3", "bgpaas_ip_address": null, "autonomous_system": 1}}, domain = default-domain]

2016 Feb 08 17:54:08.442099 csol1-node3 [:contrail-api:] : VncApiConfigLog: [VncApiCommon: identifier_uuid = 9bf9710c-eb2e-41c9-a851-ed1c5316a8e3, object_type = bgp_as_a_service, identifier_name = default-domain:bgp-test:bgpaas-3, url = http://172.16.80.200:8082/ref-update, operation = ref-update, useragent = csol1-node3:/usr/bin/contrail-schema, remote_ip = 172.16.80.200:8082, body = {"ref-type": "bgp-router", "uuid": "9bf9710c-eb2e-41c9-a851-ed1c5316a8e3", "ref-fq-name": ["default-domain", "bgp-test", "vn_private-x1-0", "vn_private-x1-0", "p0"], "ref-uuid": "ef13d906-3b2d-4aed-ad48-722d8ec372a2", "operation": "ADD", "type": "bgp-as-a-service", "attr": null}, domain = default-domain]

2016 Feb 08 17:54:16.815633 csol1-node3 [:contrail-api:] : VncApiConfigLog: [VncApiCommon: identifier_uuid = 9bf9710c-eb2e-41c9-a851-ed1c5316a8e3, object_type = bgp_as_a_service, identifier_name = default-domain:bgp-test:bgpaas-3, url = http://172.16.80.3:9100/bgp-as-a-service/9bf9710c-eb2e-41c9-a851-ed1c5316a8e3, operation = put, useragent = Restler for node.js, remote_ip = 172.16.80.3:9100, body = {"bgp-as-a-service": {"bgpaas_session_attributes": {"auth_data": null, "admin_down": false, "loop_count": 0, "passive": true, "family_attributes": [{"prefix_limit": {"maximum": 0}, "loop_count": 0, "address_family": "inet"}, {"prefix_limit": {"maximum": 0}, "loop_count": 0, "address_family": "inet6"}], "hold_time": 0, "address_families": {"family": ["inet", "inet6"]}}, "fq_nam...

[Rahul (rahuls)]

Please add UI config diff for this.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17008
Submitter: Siva Bavanasi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17008
Committed: http://github.org/Juniper/contrail-web-controller/commit/74977aa76d07cad29a730749ffa4b46f26f14364
Submitter: Zuul
Branch: master

commit 74977aa76d07cad29a730749ffa4b46f26f14364
Author: Siva Bavanasi <email address hidden>
Date: Tue Feb 9 12:19:25 2016 +0530

Closes-bug: #1542102 - BGPaaS: unsetting bgpaas IP address deletes bgp client
router
Fixed below issues as well
1)Change Ports and Interfaces labels to Virtual Machine Inetrface(s)
2)(N More) is not shown in Virtual Machine Interface(s) column if it has more
items

Change-Id: Ia4312157a371a81475688dfd45196c29e1951faf