[camera] LED & Flash toggles are shown even when no LED or Flash present on hardware

[Bill Filler]

could be Freiza specific.

We shouldn't be showing controls for flash, torchlight if they are not present on hardware, but apparently we are (according to design)

[Florian Boucault (fboucault)]

Can't test without Freiza but it's clear that the app knows how to that: test with BQ Aquaris E4.5 with front camera: no flash option is displayed.

[Bill Filler (bfiller)]

this seems to be a device specific bug where the correct camera capabilities are not being reported up the stack. Something in backend (hybris, etc) most likely needs a fix

[Pat McGowan (pat-mcgowan)]

This was reported by John also and I marked it invalid. I believe the back camera on freiza has a flash (of course it should) and its simply not working.
The front camera doesn't display a flash option.

[Pat McGowan (pat-mcgowan)]

Entered bug #1544982

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[John McAleely (john.mcaleely)]

I am not sure where Pat has the impression this tablet has a flash on the rear camera. Here is the spec:

http://www.bq.com/es/aquaris-m10

I see no flash

[John McAleely (john.mcaleely)]

I assume that our android parts are reporting a flash in error. On the other hand if there is a flash (!), then it needs to be enabled.

[Pat McGowan (pat-mcgowan)]

There is no flash apparent, all of the articles that picked up the announcement said so, I assume it was a type somewhere

[Chunsang Jeong (chunsang)]

Frieza cam doesn't have hw flash as commented earlier, meanwhile Frieza cam hal was hard coded to return 1 (has hw flash) which is apparently needed to be fixed.
Just for double check, whatever cam hal returns "has" or "doesn't has", cam ui has flash icon for main, while doesn't have it for front cam, respectively.

When Frieza cam hal got flash request, it just wrote log as below;
D/flash_mgr_m.cpp( 1130): flash_mgr_m.cpp isNeedFiringFlash() XO OO

If fixed;
D/flash_mgr_m.cpp( 1175): flash_mgr_m.cpp isNeedFiringFlash() No flash hw

[Chunsang Jeong (chunsang)]

Can someone give me a hint that how app detects if there's a hw flash or not?

[Florian Boucault (fboucault)]

The camera app checks the result of QCameraFlashControl::isFlashModeSupported(...)
http://doc.qt.io/qt-5/qcameraflashcontrol.html#isFlashModeSupported

It considers a flash is available if:
isFlashModeSupported(QCameraExposure::FlashAuto) && isFlashModeSupported(QCameraExposure::FlashOff) && isFlashModeSupported(QCameraExposure::FlashOn);

[Florian Boucault (fboucault)]

Supported modes are returned to the app via Qt which in our case uses the qtubuntu-camera plugin which itself queries the supported modes calling hybris' function android_camera_enumerate_supported_flash_modes(...)

[Chunsang Jeong (chunsang)]

@Florian

Thanks for your information.
I'd found that it was hard coded in cam hal, and already fixed it which is under reviewing.

[Pat McGowan (pat-mcgowan)]

in the device tarball at rc#5

[Ethan Chang (ethan.chang)]

Verified with RC5 image.