fuel-agent has generic names for files in /usr/bin

[Thomas Goirand]

The file in contrib/fuel_bootstrap/files/trusty/usr/bin/send2syslog.py isn't matching the Debian policy, which is no script in /usr/bin should include the shell script extension. Also, "send2syslog" is too generic. In the Debian package, I used:

/usr/bin/fa_send2syslog

Please rename it the same way upstream.

The same way, we have contrib/fuel_bootstrap/files/trusty/usr/bin/fix-configs-on-startup. In Debian, I renamed it as:

/usr/bin/fa_fix-configs-on-startup

Finally, in the main python code of fuel-agent, we have /usr/bin/provision. Please rename it as:

/usr/bin/fa_provision

I am well aware that what I have produced in Debian may not work (yet) because of these filename changes, as I did fix the internal code of fuel-agent about a year ago as a Debian patch. It is my hope though, that this will be fixed upstream the way I am suggesting.

[Thomas Goirand (thomas-goirand)]

Ah, now I remember! :)

So, only fix-configs-on-startup references send2syslog.py, so it's easy to fix. Then, instead of writing an rc.local (boooooo... ugly...), I just wrote an init script which calls /usr/bin/fa_fix-configs-on-startup. This has the same effect, but it can be packaged in a Debian policy compliant way.

Many files under contrib/fuel_bootstrap/files/trusty/etc are hardly package-able by the way. For example, contrib/fuel_bootstrap/files/trusty/etc/hostname can't be done this way. Instead, the hostname shall be fixed when preparing the image. Files like contrib/fuel_bootstrap/files/trusty/etc/modules belong to other packages (kmod in this case) and can't be replaced in this way.

So, just installing fuel-agent wont be enough for preparing the image, which is a shame. We should find some better way than just dropping files from contrib/fuel_bootstrap/files/trusty in the bootstrap image. Suggestions welcome.

[Ihor Kalnytskyi (ikalnytskyi)]

Why do we need this terrible script at the first place?

[Roman Vyalov (r0mikiam)]

reassign to mos-packaging team, because it is their responsibility

[Thomas Goirand (thomas-goirand)]

Igor, we mostly need "this terrible script" (I agree it's really ugly) in the bootstrap image, so we can have /etc/mcollective/server.cfg to be setup with the write hostname for the rabbitmq connection, depending on the url= parameter on the kernel command line.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug