Failure to update network property of Port

Bug #1541516 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Thomas Herve

Bug Description

This is a followup of bug #1514680 and the patch at https://review.openstack.org/257966.

I tried creating a Port with a network ID with a kilo-like resource (ie not translating to network internally), and then update to the master resource with a network name; and it failed while trying to validate the update (expected string or buffer).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275832

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/275832
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f0775c8d97af832583225c443726fd7ff8d73b8d
Submitter: Jenkins
Branch: master

commit f0775c8d97af832583225c443726fd7ff8d73b8d
Author: Thomas Herve <email address hidden>
Date: Wed Feb 3 18:08:53 2016 +0100

    Translate all properties during update

    This adds a translate call for before properties during update, so that
    we can retrive the proper keys when checking them in new resources. This
    also handles the network key in the Port resource to not update if
    network happens to be in the changed properties.

    Change-Id: I4d76b5f60f454babbe60832d9e81912c13d53b9c
    Closes-Bug: #1541516

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/276266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/276266
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6bb42f641ec387d46aefe45fbfea24a28f50dc32
Submitter: Jenkins
Branch: stable/liberty

commit 6bb42f641ec387d46aefe45fbfea24a28f50dc32
Author: Thomas Herve <email address hidden>
Date: Wed Feb 3 18:08:53 2016 +0100

    Translate all properties during update

    This adds a translate call for before properties during update, so that
    we can retrive the proper keys when checking them in new resources. This
    also handles the network key in the Port resource to not update if
    network happens to be in the changed properties.

    Change-Id: I4d76b5f60f454babbe60832d9e81912c13d53b9c
    Closes-Bug: #1541516
    (cherry picked from commit f0775c8d97af832583225c443726fd7ff8d73b8d)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b3

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 5.0.2

This issue was fixed in the openstack/heat 5.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.