[Core-Library] Argument 'direction' is missed in _addGroup method of AwsSecurityGroupManager class

Bug #1541477 reported by Dmytro Dovbii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Undecided
Dmytro Dovbii
Liberty
Fix Released
Undecided
Dmytro Dovbii
Mitaka
Fix Released
Undecided
Dmytro Dovbii

Bug Description

There is no `direction` argument in _addGroup() list of parameters:

https://github.com/openstack/murano/blob/master/meta/io.murano/Classes/system/AwsSecurityGroupManager.yaml#L54-L63

But it's used in method's workflow.

So, usage of this class prevents to error

Tags: core-library
Changed in murano:
assignee: nobody → Dmytro Dovbii (ddovbii)
status: New → In Progress
tags: added: core-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/275343
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=7216781c0316c5a11401ed04d1a82fe6fb09b0db
Submitter: Jenkins
Branch: master

commit 7216781c0316c5a11401ed04d1a82fe6fb09b0db
Author: Dmytro Dovbii <email address hidden>
Date: Tue Feb 2 19:37:09 2016 +0200

    [Core-Library] Add 'direction' argument to '_addGroup' method

    Closes-Bug: #1541477

    Change-Id: I76c9d3bc7e1f25a734393f15c32896437bd7230a

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/276122

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/liberty)

Reviewed: https://review.openstack.org/276122
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=2ff923a3179e64766a3917efde5c2148bcd6073d
Submitter: Jenkins
Branch: stable/liberty

commit 2ff923a3179e64766a3917efde5c2148bcd6073d
Author: Dmytro Dovbii <email address hidden>
Date: Tue Feb 2 19:37:09 2016 +0200

    [Core-Library] Add 'direction' argument to '_addGroup' method

    Closes-Bug: #1541477

    Change-Id: I76c9d3bc7e1f25a734393f15c32896437bd7230a
    (cherry picked from commit 7216781c0316c5a11401ed04d1a82fe6fb09b0db)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2.0.0.0b3

This issue was fixed in the openstack/murano 2.0.0.0b3 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 1.0.3

This issue was fixed in the openstack/murano 1.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/murano 1.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.