Network template's order cannot be specified for set of roles

[slava valyavskiy]

For example we have following network template and 'default-common' is representing set of actions what should be performed in the end of network actions in any case:

    templates_for_node_role:
      compute:
      - cpu
      - default-common
      virt:
      - virt
      - default-common

Our current python implementation[0] will handle this template for node with roles 'virt+compute' in following order:
      - cpu
      - default-common
      - virt

So, there is no way to move 'default-common' scheme in the end of network templates queue.

https://github.com/openstack/fuel-web/blob/stable/8.0/nailgun/nailgun/orchestrator/neutron_serializers.py#L1184-L1209 [0]

[Matthew Mosesohn (raytrac3r)]

This will not get fixed by 8.0 HCF. Moving to 8.0 updates

[Dmitry Klenov (dklenov)]

Raising priority to critical for 7.0 as it is blocking periodic releases for a major customer.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/276125

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/274931
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=35726f4e9bba16327229355c6f5d90ead5867854
Submitter: Jenkins
Branch: master

commit 35726f4e9bba16327229355c6f5d90ead5867854
Author: slava <email address hidden>
Date: Tue Feb 2 02:11:44 2016 +0300

    Introduce priorities for network_schemes

    Currently we have no way to control templates applying order
    for set of roles(cinder+compute). This patch introduces ability
    to specify absolute priority for template to make it possible for
    operator to manage templates order. Patch doesn't affect order of
    templates where 'priority' field is not specified.

    Change-Id: I4348d3dea2c382837eb7f96e5b0ae3eb0312c8ad
    Closes-bug: 1540374

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/281161

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/276125
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1410c5e75fdb06531d744a90f04607a350a7af3f
Submitter: Jenkins
Branch: stable/7.0

commit 1410c5e75fdb06531d744a90f04607a350a7af3f
Author: slava <email address hidden>
Date: Tue Feb 2 02:11:44 2016 +0300

    Introduce priorities for network_schemes

    Currently we have no way to control templates applying order
    for set of roles(cinder+compute). This patch introduces ability
    to specify absolute priority for template to make it possible for
    operator to manage templates order. Patch doesn't affect order of
    templates where 'priority' field is not specified.

    Change-Id: I4348d3dea2c382837eb7f96e5b0ae3eb0312c8ad
    Closes-bug: 1540374

[Ekaterina Shutova (eshutova)]

Verified on MOS 7.0 + mu3 updates.

Scenario:
1) Upload network template to master node http://paste.openstack.org/show/492250/
2) fuel network-template --env X --upload
3) fuel --env X deployment default
4) Check that transformations order corresponds priority for node roles.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281161
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=0663c3bf3e329cef9d89db626e6a8aaec4deddf1
Submitter: Jenkins
Branch: stable/8.0

commit 0663c3bf3e329cef9d89db626e6a8aaec4deddf1
Author: slava <email address hidden>
Date: Tue Feb 2 02:11:44 2016 +0300

    Introduce priorities for network_schemes

    Currently we have no way to control templates applying order
    for set of roles(cinder+compute). This patch introduces ability
    to specify absolute priority for template to make it possible for
    operator to manage templates order. Patch doesn't affect order of
    templates where 'priority' field is not specified.

    Change-Id: I4348d3dea2c382837eb7f96e5b0ae3eb0312c8ad
    Closes-bug: 1540374
    (cherry picked from commit 35726f4e9bba16327229355c6f5d90ead5867854)

[Ekaterina Shutova (eshutova)]

Verified on MOS 8.0 + mu1 updates.

Scenario:
1) Upload network template to master node http://paste.openstack.org/show/492250/ (update interfaces names)
2) fuel network-template --env X --upload
3) fuel --env X deployment default
4) Check that transformation's order corresponds priority for node roles. Change priority and check that transormations also changes.

[Vitaly Sedelnik (vsedelnik)]

Retargeted to 8.0-mu-2 as we cannot complete nailgun testing in frame of 8.0-mu-1.

[Alisa Tselovalnikova (atselovalnikova)]

Verified on http://paste.openstack.org/show/516793.

Verification steps:
    1. Upload network template to master node http://paste.openstack.org/show/492250/ (update
       interfaces names)
    2. fuel network-template --env X --upload
    3. fuel --env X deployment default
    4. Check that transformation's order corresponds priority for node roles. Change priority and
       check that transormations also changes.

All steps are passed.

[Ekaterina Shutova (eshutova)]

Verified on MOS 8.0 + mu2 updates.

Used scenario:
1) Create simple cluster(controller+compute+cinder)
2) Upload network template to master node http://paste.openstack.org/show/492250/ (update interfaces names)
3) fuel network-template --env X --upload
4) fuel --env X deployment default
5) Check that transformation's order corresponds priority for node roles. Change priority and check that transormations also changes.