Fuel allow apply changes even if deployment task still in progress

Bug #1539693 reported by Ivan Ponomarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Fedor Zhadaev
8.0.x
Fix Released
High
Fedor Zhadaev
Mitaka
Fix Released
High
Fedor Zhadaev

Bug Description

Step to reproduce.
1) Create environment 3 controller 1 compute
2) Shutdown one node (primary node)
3) Wait when node goes offline
4) Remove this node (curl': curl -X "DELETE" http://localhost:8000/api/nodes/1 -H "X-Auth-Token: c8c10ee77c004206a9b8196080ed608f")
5) Do not wait end of deployment ends, add new controller and apply changes.

Expected result:
Deploy is passed. Or error should appear if one of deploy still in progress

Actual result:
Deploy are failed with timeout error. But astute is still working, actually deploy is in progress.

I think second deployment task start counting of timeout and does not wait when previous task ended:

[root@nailgun ~]# fuel task
id | status | name | cluster | progress | uuid
---|---------|-------------------|---------|----------|-------------------------------------
11 | ready | create_stats_user | 1 | 100 | 88e8dac9-c6b7-4656-a429-0174233ca761
15 | ready | check_networks | 1 | 100 | d7f0e4ee-d288-4e22-aa10-bd50211d107b
13 | running | deployment | 1 | 51 | 8c9b2727-f106-4dd1-a2ff-0a35748d0582
12 | ready | node_deletion | 1 | 51 | 5713df93-c2ee-4f2e-842e-ddadea25ea44
19 | running | deployment | 1 | 0 | c1288d6d-c2a1-4e3f-be55-12b908d185c8
18 | running | provision | 1 | 40 | b5554c5f-bc72-49ee-9133-e70e4ef24772
14 | running | deploy | 1 | 48 | ff2e08af-0ebb-42b0-86f6-e5f34ef98b55
[root@nailgun ~]# fuel task
id | status | name | cluster | progress | uuid
---|---------|-------------------|---------|----------|-------------------------------------
11 | ready | create_stats_user | 1 | 100 | 88e8dac9-c6b7-4656-a429-0174233ca761
15 | ready | check_networks | 1 | 100 | d7f0e4ee-d288-4e22-aa10-bd50211d107b
18 | ready | provision | 1 | 100 | b5554c5f-bc72-49ee-9133-e70e4ef24772
13 | running | deployment | 1 | 11 | 8c9b2727-f106-4dd1-a2ff-0a35748d0582
12 | ready | node_deletion | 1 | 11 | 5713df93-c2ee-4f2e-842e-ddadea25ea44
19 | running | deployment | 1 | 11 | c1288d6d-c2a1-4e3f-be55-12b908d185c8
14 | running | deploy | 1 | 63 | ff2e08af-0ebb-42b0-86f6-e5f34ef98b55

 release: "8.0"
  api: "1.0"
  build_number: "496"
  build_id: "496"
  fuel-nailgun_sha: "934c2d11b234193c6ac8e41cd1388df0ed3583e0"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "e40bcfbb1f5518d7a464cc330909cf09b84e7c20"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "b91e96e848057be4acadd10c2b55a6529387fe51"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "6b993b3004e8d97d840b672d6c1d44c320975cd9"

Related bug:
https://bugs.launchpad.net/fuel/+bug/1496411

description: updated
Changed in fuel:
milestone: none → 8.0
Changed in fuel:
milestone: 8.0 → 9.0
status: New → Confirmed
tags: added: team-bugfix
Andrey Maximov (maximov)
tags: added: hit-hcf
Revision history for this message
Fedor Zhadaev (fzhadaev) wrote :

For some reason fix is not handled by LP. But it was proposed to fuel-web (master).
https://review.openstack.org/#/c/275239/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/275239
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5853b90e8a1c4c3772a70aa82f1ab6f9b3df6afd
Submitter: Jenkins
Branch: master

commit 5853b90e8a1c4c3772a70aa82f1ab6f9b3df6afd
Author: Fedor Zhadaev <email address hidden>
Date: Tue Feb 2 17:40:41 2016 +0300

    Add check for active deployment

     * Check for active `deployment` and `provision` tasks
       when running new deployment

    Change-Id: I489c6444cd6822cd0b08b074edf420e66014f0f8
    Closes-Bug: #1539693

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/275686

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/8.0)

Reviewed: https://review.openstack.org/275686
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=0ad55bf168a46937b08b4fa634828a41f44075c0
Submitter: Jenkins
Branch: stable/8.0

commit 0ad55bf168a46937b08b4fa634828a41f44075c0
Author: Fedor Zhadaev <email address hidden>
Date: Tue Feb 2 17:40:41 2016 +0300

    Add check for active deployment

     * Check for active `deployment` and `provision` tasks
       when running new deployment

    Change-Id: I489c6444cd6822cd0b08b074edf420e66014f0f8
    Closes-Bug: #1539693
    (cherry picked from commit 5853b90e8a1c4c3772a70aa82f1ab6f9b3df6afd)

tags: added: on-verification
Revision history for this message
Veronica Krayneva (vkrayneva) wrote :

Verified on #522 iso

tags: removed: on-verification
tags: added: on-verification
Revision history for this message
Dmitriy Kruglov (dkruglov) wrote :

Verified on MOS 9.0, ISO #467.
The issue is fixed.

ISO details:
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 467
cat /etc/fuel_build_number:
 467
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8454.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8454.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8742.noarch
 fuel-notify-9.0.0-1.mos8454.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8454.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8742.noarch
 fuel-library9.0-9.0.0-1.mos8454.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8742.noarch

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
tags: added: on-verification
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.