hwup does not enable qeth when qeth driver is in the kernel (not a module)

Bug #1539624 reported by bugproxy
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sysconfig (Debian)
Fix Released
Unknown
sysconfig (Ubuntu)
Fix Released
Undecided
Dimitri John Ledkov

Bug Description

== Comment: #0 - EVGENY CHERKASHIN <email address hidden> - 2016-01-29 06:22:37 ==
When you boot a kernel that has qeth drivers (core, l2 and l3) compiled into the kernel as opposed to as modules, network interfaces fail to come up. E.g if you have this configuration:

root@r35lp54:~# cat /etc/sysconfig/hardware/config-ccw-0.0.f100
CCWGROUP_CHANS=(0.0.f100 0.0.f101 0.0.f102)
QETH_PORTNAME=OSAPORT
QETH_PORTNO=0
QETH_OPTIONS=()
INTERFACE_NAME=eth1

and run `hwup` command, you get this error message:

root@r35lp54:~# hwup ccw 0.0.f100
no kernel module for qeth devices available!

Apparently `hwup-ccw-group` unconditionally runs `modprobe`; it should skip this step if the driver is already in the kernel.

== Comment: #1 - Hendrik Brueckner <email address hidden> - 2016-01-29 06:37:12 ==
(In reply to comment #0)
> When you boot a kernel that has qeth drivers (core, l2 and l3) compiled into
> the kernel as opposed to as modules, network interfaces fail to come up. E.g
> if you have this configuration:
>
> root@r35lp54:~# cat /etc/sysconfig/hardware/config-ccw-0.0.f100
> CCWGROUP_CHANS=(0.0.f100 0.0.f101 0.0.f102)
> QETH_PORTNAME=OSAPORT
> QETH_PORTNO=0
> QETH_OPTIONS=()
> INTERFACE_NAME=eth1
>
> and run `hwup` command, you get this error message:
>
> root@r35lp54:~# hwup ccw 0.0.f100
> no kernel module for qeth devices available!
>
> Apparently `hwup-ccw-group` unconditionally runs `modprobe`; it should skip
> this step if the driver is already in the kernel.

Excerpt from hwup-ccw-group:
--------------------
elif [ "$NAME" == qeth ]; then
  modprobe qeth 2> /dev/null || :

  if [ -d $SYSFS/module/qeth ]; then
    DRIVER=qeth
  else
    error "no kernel module for qeth devices available!"
  fi
fi
-------------------

Loading the module unconditionally is fine. To correct the problem, the check for $SYSFS/module/qeth needs to be updated, for example:

/sys/bus/ccw/drivers/qeth
/sys/devices/qeth

== Comment: #2 - Hendrik Brueckner <email address hidden> - 2016-01-29 06:53:03 ==
A Debian bug report against the sysconfig-hardware package has been submitted. I will update the bugzilla when I have the debian bug number available.

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2016-01-29 09:28 EDT-------
The Debian bug for this issue is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813098

tags: added: architecture-s39064 bugnameltc-136243 severity-medium targetmilestone-inin1604
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
affects: ubuntu → sysconfig (Ubuntu)
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2016-01-29 09:36 EDT-------
Comment by Hendrik:

The Debian bug for this issue is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813098

dann frazier (dannf)
Changed in sysconfig (Ubuntu):
assignee: Taco Screen team (taco-screen-team) → Skipper Bug Screeners (skipper-screen-team)
dann frazier (dannf)
Changed in sysconfig (Ubuntu):
assignee: Skipper Bug Screeners (skipper-screen-team) → Canonical Foundations Team (canonical-foundations)
Steve Langasek (vorlon)
Changed in sysconfig (Ubuntu):
assignee: Canonical Foundations Team (canonical-foundations) → Dimitri John Ledkov (xnox)
Changed in sysconfig (Debian):
status: Unknown → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in sysconfig (Ubuntu):
status: New → Confirmed
Changed in sysconfig (Debian):
status: New → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

For future reference, one is allowed to close LP: # bug number in Debian changelogs, with uploads done in Debian. Then this bug, for example, would have been automatically close via upload to Debian (after all conditions are satisfied, e.g. package is synced, builds, got automatically tested, migrates and finally is published).

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

In release pocket since 7th of February.

https://launchpad.net/ubuntu/+source/sysconfig/0.0.12

Changed in sysconfig (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2016-02-17 05:29 EDT-------
Was verified. Works now.

# dpkg -s sysconfig-hardware | grep 'Version'
Version: 0.0.12

# hwup ccw 0.0.b100
Configuring device 0.0.b100: ok. (portname OSAPORT) (portno 0) ok.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.