permission on swift log directories incorrect

[Alex]

On liberty branch, was not seeing any log files for swift. Turns out log dirs were owned by swift:swift, but all logging goes through syslog, so must be syslog:syslog.

Simple patch is below:

diff --git a/playbooks/roles/os_swift/tasks/swift_pre_install.yml b/playbooks/roles/os_swift/tasks/swift_pre_install.yml
index 5bb0c3f..e3a292e 100644
--- a/playbooks/roles/os_swift/tasks/swift_pre_install.yml
+++ b/playbooks/roles/os_swift/tasks/swift_pre_install.yml
@@ -87,8 +87,8 @@
 - name: Test for log directory or link
   shell: |
     if [ -h "/var/log/swift" ]; then
- chown -h {{ swift_system_user_name }}:{{ swift_system_group_name }} "/var/log/swift"
- chown -R {{ swift_system_user_name }}:{{ swift_system_group_name }} "$(readlink /var/log/swift)"
+ chown -h syslog:syslog "/var/log/swift"
+ chown -R syslog:syslog "$(readlink /var/log/swift)"
     else
       exit 1
     fi

[Jesse Pretorius (jesse-pretorius)]

Better to patch https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_swift/tasks/swift_pre_install.yml#L90-L91 to use the syslog user - this allows swift to write there and rsyslog to read there.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/275311

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/287926

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Carter (<email address hidden>) on branch: master
Review: https://review.openstack.org/275311

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Carter (<email address hidden>) on branch: master
Review: https://review.openstack.org/287926
Reason: This patch is no longer needed as its being resolved here: https://review.openstack.org/#/c/287926/