Use custom pid file for the rabbimq to not interfere with the murano rabbit instance

[Bogdan Dobrelya]

The patch [0] had been partially undone when we switched to the upstream OCF manifest for the rabbitmq. Specifically, the change was undone:

-OCF_RESKEY_pid_file_default=/var/run/rabbitmq/pid
+OCF_RESKEY_pid_file_default=/var/run/rabbitmq/p_pid

But we want it to be configured as the /var/run/rabbitmq/p_pid instead, so the OCF RA's parameter pid_file must be specified in the resource params [1] as well.

[0] https://review.openstack.org/#/c/129925/
[1] https://git.openstack.org/cgit/openstack/fuel-library/tree/deployment/puppet/pacemaker_wrappers/manifests/rabbitmq.pp#n88

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/274027

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/275114

[Matthew Mosesohn (raytrac3r)]

This bug won't be fixed in time for 8.0 HCF. Marking as proposed for maintenance update.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/274027
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=886e3a08f78e64ff5e26915196dd10550ced5b4f
Submitter: Jenkins
Branch: master

commit 886e3a08f78e64ff5e26915196dd10550ced5b4f
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Jan 29 11:19:13 2016 +0100

    Fix the pidfile and filelimits for rabbitmq

    - Fix the pidfile configuraion
    - Use the file_limit parameter of the upstream module
      to configure file limits
    - Replace duplicating tcp_listen_options to the param tcp_keepalive=true
    - Remove hardcoded management port config to be hiera-driven as well
    - Add noop tests coverage
    - Use https://github.com/fuel-infra

    Closes-bug: #1539170
    Related-bug: #1534560

    Change-Id: I2598587f6992780ee2ec345541808e29b9d24d7e
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/275114
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b55ad3778de4f5528e422b40c13b752c83418688
Submitter: Jenkins
Branch: stable/8.0

commit b55ad3778de4f5528e422b40c13b752c83418688
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Jan 29 11:19:13 2016 +0100

    Fix the pidfile and filelimits for rabbitmq

    Note, this is a partial backport which only
    fixes the pidfile configuraion.

    Closes-bug: #1539170

    Change-Id: I2598587f6992780ee2ec345541808e29b9d24d7e
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 2bd128fd90729b8ce5c94319c14742a7888bf002)
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[Maksym Strukov (unbelll)]

Verified as fixed in 8.0-566

/var/run/rabbitmq/p_pid exists

[Alexey Galkin (agalkin)]

Verified as fixed in 9.0-242.

root@node-1:~# file /var/run/rabbitmq/p_pid
/var/run/rabbitmq/p_pid: ASCII text