Results model updates performance is poor with hundreds of results
Bug #1539137 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-shell (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
Bug Description
The implementation of incremental result model updates have some bottlenecks and doesn't scale well when number of results increases. This is not visible with the number of results we currently have on the phone, but it gets really bad if scope pushes hundreds of them.
Related branches
lp:~stolowski/unity-scopes-shell/diff-updates-performance
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 1263 lines (+304/-103)47 files modifiedCMakeLists.txt (+1/-0)
debian/rules (+1/-1)
po/am.po (+2/-1)
po/ar.po (+2/-1)
po/ast.po (+2/-1)
po/br.po (+2/-1)
po/ca.po (+2/-1)
po/cs.po (+2/-1)
po/cy.po (+2/-1)
po/da.po (+2/-1)
po/de.po (+2/-1)
po/el.po (+2/-1)
po/en_AU.po (+2/-1)
po/en_GB.po (+2/-1)
po/eo.po (+2/-1)
po/es.po (+2/-1)
po/eu.po (+2/-1)
po/fa.po (+2/-1)
po/fi.po (+2/-1)
po/fr.po (+2/-1)
po/gd.po (+2/-1)
po/gl.po (+2/-1)
po/hu.po (+2/-1)
po/it.po (+2/-1)
po/ja.po (+2/-1)
po/nb.po (+2/-1)
po/nl.po (+2/-1)
po/pl.po (+2/-1)
po/pt.po (+2/-1)
po/pt_BR.po (+2/-1)
po/ro.po (+2/-1)
po/ru.po (+2/-1)
po/sl.po (+2/-1)
po/sr.po (+2/-1)
po/sv.po (+2/-1)
po/ta.po (+2/-1)
po/uk.po (+2/-1)
po/zh_CN.po (+2/-1)
po/zh_TW.po (+2/-1)
src/Unity/resultsmap.cpp (+34/-27)
src/Unity/resultsmap.h (+25/-3)
src/Unity/resultsmodel.cpp (+73/-26)
src/Unity/resultsmodel.h (+11/-0)
src/Unity/scope.cpp (+9/-1)
src/Unity/scope.h (+1/-0)
tests/data/mock-scope-manyresults/mock-scope-manyresults.cpp (+36/-8)
tests/resultstest.cpp (+39/-0)
| summary: |
- Results model updates performance is poor + Results model updates performance is poor with hundreds of results |
| Changed in unity-scopes-shell (Ubuntu): | |
| importance: | Undecided → High |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| status: | New → Confirmed |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
