out-of-bounds read in MagickCore/memory.c:718:10

[Moshe Kaplan]

This bug was found while fuzzing ImageMagick with afl-fuzz

Tested on ImageMagick version Tested on git commit 8bc3ab67d818204fe5f0fe1dc29b873d37360461

Command: magick id:000204,sig:06,src:003533,op:havoc,rep:4 /dev/null

=================================================================
==14255==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xb540771c at pc 0x8196d1f bp 0xbfdec968 sp 0xbfdec960
READ of size 5632 at 0xb540771c thread T0
    #0 0x8196d1e in CopyMagickMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:718:10
    #1 0x8763497 in RemoveResolutionFromResourceBlock /home/user/Desktop/ImageMagick/coders/psd.c:2617
    #2 0x8763497 in WritePSDImage /home/user/Desktop/ImageMagick/coders/psd.c:2775
    #3 0x8a9e9d8 in WriteImage /home/user/Desktop/ImageMagick/MagickCore/constitute.c:1091
    #4 0x8aa23bc in WriteImages /home/user/Desktop/ImageMagick/MagickCore/constitute.c:1309
    #5 0x9371daf in CLINoImageOperator /home/user/Desktop/ImageMagick/MagickWand/operation.c:4697
    #6 0x9379bc1 in CLIOption /home/user/Desktop/ImageMagick/MagickWand/operation.c:5157
    #7 0x91080c3 in ProcessCommandOptions /home/user/Desktop/ImageMagick/MagickWand/magick-cli.c:526
    #8 0x910a545 in MagickImageCommand /home/user/Desktop/ImageMagick/MagickWand/magick-cli.c:786
    #9 0x910ea29 in MagickCommandGenesis /home/user/Desktop/ImageMagick/MagickWand/mogrify.c:172
    #10 0x80de12d in MagickMain /home/user/Desktop/ImageMagick/utilities/magick.c:74
    #11 0x80de12d in main /home/user/Desktop/ImageMagick/utilities/magick.c:85
    #12 0xb751ba82 in __libc_start_main /build/buildd/eglibc-2.19/csu/libc-start.c:287
    #13 0x80ddf54 in _start (/usr/local/bin/magick+0x80ddf54)

0xb540771c is located 540 bytes to the right of 4096-byte region [0xb5406500,0xb5407500)
freed by thread T0 here:
    #0 0x80c69c1 in __interceptor_free (/usr/local/bin/magick+0x80c69c1)
    #1 0x8197c58 in RelinquishMagickMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:974

previously allocated by thread T0 here:
    #0 0x80c6b81 in malloc (/usr/local/bin/magick+0x80c6b81)
    #1 0x8193319 in AcquireMagickMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:475
    #2 0x8193319 in AcquireQuantumMemory /home/user/Desktop/ImageMagick/MagickCore/memory.c:548

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/Desktop/ImageMagick/MagickCore/memory.c:718 CopyMagickMemory
Shadow bytes around the buggy address:
  0x36a80e90: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x36a80ea0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80eb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80ec0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80ed0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x36a80ee0: fa fa fa[fa]fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80ef0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80f00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80f10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80f20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x36a80f30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable: 00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone: fa
  Heap right redzone: fb
  Freed heap region: fd
  Stack left redzone: f1
  Stack mid redzone: f2
  Stack right redzone: f3
  Stack partial redzone: f4
  Stack after return: f5
  Stack use after scope: f8
  Global redzone: f9
  Global init order: f6
  Poisoned by user: f7
  ASan internal: fe
==14255==ABORTING

[Moshe Kaplan (moshekaplan)]

input file to trigger crash

[Moshe Kaplan (moshekaplan)]

Reported and fixed upstream at: https://github.com/ImageMagick/ImageMagick/issues/109

[Launchpad Janitor (janitor)]

This bug was fixed in the package imagemagick - 8:6.9.6.6+dfsg-1ubuntu3

---------------
imagemagick (8:6.9.6.6+dfsg-1ubuntu3) zesty; urgency=medium

  * debian/patches/0020-Revert-GradientImage-change.patch: Revert patch
    per https://github.com/ImageMagick/ImageMagick/issues/316. Thanks
    to Cristy <email address hidden>. Closes LP: #1645406.

 -- Nishanth Aravamudan <email address hidden> Tue, 06 Dec 2016 17:26:36 +0100