DVR router may be constantly rescheduled in case one of dvr_snat agents is down

[Oleg Bondarev]

Another consequence of dvr scheduling mess (wchich will be finally fixed in Mitaka!)

We only want to reschedule dvr router from down agent if it's hosting SNAT for that router.
Currently it's not the case: so if any of dvr_snat agents to which distributed portion of a router is scheduled is down - router will be rescheduled. Need to check and only reschedule dvr router if it's snat is on down agent.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/16520

[Alexander Ignatov (aignatov)]

Fix is in the review, will be fixed before HCF.

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/16520
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: c1dbbc3423b097f71070c9bd52945f929b1ad0da
Author: Oleg Bondarev <email address hidden>
Date: Tue Feb 2 15:29:47 2016

Do not reschedule dvr router if any snat agent goes down

We only want to reschedule dvr router from down agent if that
agent is hosting SNAT for the router.
Currently it's not the case: so if any of dvr_snat agents to which
distributed portion of a router is scheduled is down - router will
be rescheduled. Need to check and only reschedule dvr router if
it's snat is on down agent.

The fix is to get down bindings for dvr routers separately.

Closes-Bug: #1538994
Change-Id: Ia75e38cbe154ac837d09198b8487bfb01c99b30f

[Kristina Berezovskaia (kkuznetsova)]

Verify on
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "543"
  build_id: "543"
  fuel-nailgun_sha: "baec8643ca624e52b37873f2dbd511c135d236d9"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "e2d79330d5d708796330fac67722c21f85569b87"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "87dfb6bc25d4650264f09c338ed77c21a3d6fe87"
(vxlan+l2+dvr, 3 controllers, 2 compute)

1) Create net1, subnet1
2) Create DVR router, set gateway, add interface to net1
3) Boot vm in net1
5) Check that ping 8.8.8.8 is available from vm
6) Create net2, subnet2
7) Create DVR router, set gateway, add interface to net2
8) Boot vm in net2
9) Find node with snat for the first router and the second (they should be different, if not, reschedule manually)
6) Ban l3-agent on node with snat for the first router
7) Wait some time
8) Check that snat for the second router didn't reschedule on another node

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/18416

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Oleg Bondarev <email address hidden> on branch: 9.0/mitaka
Review: https://review.fuel-infra.org/18416
Reason: Not needed since
bp/improve-dvr-l3-agent-binding was implemented in Mitaka