BGPaaS: don't create peering relationship between bgpaas-server and MX

[amit surana]

A sequence of operations can lead to a spurious relationship between MX bgp-router and bgpaas-server bgp-router object. Once this happens, DM will pick this up and try to configure the bgpaas-server as a MX neighbor, which is not what we want. Configuration commits on MX will fail and impact rest of the system.

the sequence that leads to this:

1. create bgpaas object, attach to vmi.
2. delete bgpaas object.
3. bgp-client object is deleted after step 2, but bgpaas-server object isn't (cause VN/RI are still present)
4. restart config services.

post restart, the bug is seen.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16760
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16760
Committed: http://github.org/Juniper/contrail-controller/commit/d239035ec3525365f315192fec8e4f958560f6d7
Submitter: Zuul
Branch: master

commit d239035ec3525365f315192fec8e4f958560f6d7
Author: sbalineni <email address hidden>
Date: Mon Feb 1 11:01:02 2016 -0800

BGPaaS - vmi primary ip address is used as BGPaaS object if not configured.
Read and initalize Bgpaas objects when ST is reinited.

Change-Id: I3f0a4da86d708464de7d0b4ba41ae6e7a5faabb8
Closes-Bug: #1538322
Closes-Bug: #1538318
Closes-Bug: #1536339
Closes-Bug: #1540540

[amit surana (asurana-t)]

Bug is still seen. BGP-client/server router objects are getting peered with MX.

2820 if not self.router_type:
2821 if router.router_type in ('bgpaas-server', 'bgpaas-client'):
2822 continue

change the above to:

                      if router.router_type in ('bgpaas-server', 'bgpaas-client'):
                                continue

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17687
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17749
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17687
Committed: http://github.org/Juniper/contrail-controller/commit/78745ca0de127019fc51aac3b5c56bdad0ff553a
Submitter: Zuul
Branch: master

commit 78745ca0de127019fc51aac3b5c56bdad0ff553a
Author: sbalineni <email address hidden>
Date: Tue Feb 23 14:18:52 2016 -0800

ST: Assign SC RI in reverse path when directional policy is configured

When a network policy is configured with birectional flow, ACLs should have
assign rule with SC RI in both of the directions.

For example:
if policy P1 is configured with src: vn1, dst: vn2, direction <> and applied to vn1
then ACL are generated as follows:
vn1->vn2, action: assign-vrf=>vn1-sc-ri and vn2->vn1, action: assign-vrf=>vn1-sc-ri

Also fixed a case of peering MX with BgpAsAService BGP Server/Client

Change-Id: Iab988483416b1c13fab489472f4db9e29861a64f
Closes-Bug: #1543038
Closes-Bug: #1538318

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17749
Committed: http://github.org/Juniper/contrail-controller/commit/c061f3b7c5456a800c3da731172f6a90a19040e5
Submitter: Zuul
Branch: R3.0

commit c061f3b7c5456a800c3da731172f6a90a19040e5
Author: sbalineni <email address hidden>
Date: Tue Feb 23 14:18:52 2016 -0800

ST: Assign SC RI in reverse path when directional policy is configured

When a network policy is configured with birectional flow, ACLs should have
assign rule with SC RI in both of the directions.

For example:
if policy P1 is configured with src: vn1, dst: vn2, direction <> and applied to vn1
then ACL are generated as follows:
vn1->vn2, action: assign-vrf=>vn1-sc-ri and vn2->vn1, action: assign-vrf=>vn1-sc-ri

Also fixed a case of peering MX with BgpAsAService BGP Server/Client

Change-Id: Iab988483416b1c13fab489472f4db9e29861a64f
Closes-Bug: #1543038
Closes-Bug: #1538318