change image from dict to object

Bug #1537921 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-zvm-virt-driver
Fix Committed
Medium
Huang Rui

Bug Description

commit fbe31e461ac3f16edb795993558a2314b4c16b52
Author: Daniel P. Berrange <email address hidden>
Date: Mon Jun 8 17:58:09 2015 +0100

    compute: convert manager to use nova.objects.ImageMeta

    Update the virt driver API so that all methods with an
    'image_meta' parameter take a nova.objects.ImageMeta
    instance instead of a dict.

    NB, this will break out of tree virt drivers until they
    convert their code to use the new object.

    Blueprint: mitaka-objects
    Change-Id: I75465a2029b53aa4d338b80619ed7380e0d19e6a

this patches change image_meta from dict to object in virt layer

all image reference such as image_meta['properties']['os_version']
cannot be used anymore, we need to figure out a way

Revision history for this message
Huang Rui (bjhuangr) wrote :

Block CI test

Changed in nova-zvm-virt-driver:
importance: Undecided → Medium
assignee: nobody → jichenjc (jichenjc)
assignee: jichenjc (jichenjc) → Huang Rui (bjhuangr)
Revision history for this message
jichenjc (jichenjc) wrote :

Found this issue in our z/VM CI test

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova-zvm-virt-driver (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/272980

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova-zvm-virt-driver (master)

Reviewed: https://review.openstack.org/272980
Committed: https://git.openstack.org/cgit/openstack/nova-zvm-virt-driver/commit/?id=fefa517c4dbe45737995a862d5a654ab4b206889
Submitter: Jenkins
Branch: master

commit fefa517c4dbe45737995a862d5a654ab4b206889
Author: jichenjc <email address hidden>
Date: Sun Jan 24 08:47:30 2016 +0800

    Get image_metadata through glance service

    zvm driver have several attributes that is into image_meta
    object, this means it can't get the value from nova compute
    layer passed down param, so need to get image from glance
    again to guarantee those values can be got.

    Change-Id: I70ae2fdbe80e416b01719354f4ed8e0e609bc9e1
    Related-Bug: 1537921

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova-zvm-virt-driver (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/276665

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova-zvm-virt-driver (master)

Reviewed: https://review.openstack.org/276665
Committed: https://git.openstack.org/cgit/openstack/nova-zvm-virt-driver/commit/?id=7fde8d4df5dafba4cd636812b5e4b77e1784cf47
Submitter: Jenkins
Branch: master

commit 7fde8d4df5dafba4cd636812b5e4b77e1784cf47
Author: jichenjc <email address hidden>
Date: Wed Jan 27 00:53:30 2016 +0800

    Change imagemeta from dict to obj in test

    return object directly to test case to make the
    hacking take effect.

    Change-Id: I696a5e32ae935fb892451ccfcdd912c91aa91087
    Related-Bug: 1537921

Dirk Mueller (dmllr)
Changed in nova-zvm-virt-driver:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.