Instance Metadata should only show metadata definitions with properties_target: metadata

[Travis Tripp]

The ability to add metadata to an instance leveraging these definitions at launch time was recently added to horizon. [0] It was also added as an action on the instances table [1].

[0] https://review.openstack.org/209680
[1] https://review.openstack.org/243624

 In a follow up discussion, somebody asked about using the metadata definitions to also choose nova scheduler hints at launch time and how to make sure that the two weren't confused. This raised our awareness that we don't have properties_target set to "metadata" (rather than "scheduler_hints") for OS::Nova::Instance on the following software namespace files:
The metadata definitions the Glance Metadata Definitions catalog allow each namespace to be associated with a resource type in OpenStack. Some types of resources have more than one type of properties, so the namespaces allow this to be specified using a properties_target attribute.

We have now updated the existing namespaces in Glance for OS::Nova::Instance to have a properties target set to "metadata" [3].

[3] https://review.openstack.org/#/c/271100

So, the NG launch instance metadata step and project update metadata action should be updated to only show namespaces that have have the properties_target of metadata set.

Please note that there will be an additional bug opened on glance to change these namespaces from OS::Glance::Instance to OS::Nova::Server to align with the heat resource type.

http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::Server

** It should be noted that updating namespaces is already possible with glance-manage. E.g.

ttripp@ubuntu:/opt/stack/glance$ glance-manage db_load_metadefs etc/metadefs -h
usage: glance-manage db_load_metadefs [-h]
                                      [path] [merge] [prefer_new] [overwrite]

positional arguments:
  path
  merge
  prefer_new
  overwrite

So, you just have to call:

ttripp@ubuntu:/opt/stack/glance$ glance-manage db_load_metadefs etc/metadefs true true

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272305

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272305
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e55240d882baf0ec8c19deaef9b9d0ba60b59100
Submitter: Jenkins
Branch: master

commit e55240d882baf0ec8c19deaef9b9d0ba60b59100
Author: Justin Pomeroy <email address hidden>
Date: Mon Jan 25 16:20:07 2016 -0600

    Support properties_target when fetching namespaces

    This allows specifying a properties target when fetching metadata
    definitions namespaces from glance, and updates the instance
    metadata widget to show only "metadata" properties (as opposed to
    "scheduler_hints") when creating an instance or updating the
    metadata.

    Closes-Bug: #1537842
    Change-Id: I64dd279139eca2cbd0c0a6e808ade4cbcba8df95

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.