Users cannot clear allowed address pairs from a port via --action=clear parameter from neutronclient

[Sean M. Collins]

http://lists.openstack.org/pipermail/openstack-dev/2016-January/084819.html

It appears that the validator "validate_allowed_address_pairs" does not take into account the --action=clear parameter that is used to update a port and remove allowed address pairs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/273018

[Armando Migliaccio (armando-migliaccio)]

This is a small issue with an easy workaround, hence lower importance.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/273018
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8052c3985325e9067d83496936092ee9334df75b
Submitter: Jenkins
Branch: master

commit 8052c3985325e9067d83496936092ee9334df75b
Author: Kevin Benton <email address hidden>
Date: Wed Jan 27 04:34:54 2016 -0800

    Allow address pairs to be cleared with None

    When the neutron client attempts to clear the allowed
    address pairs using the '--action=clear' CLI param, it
    sends a value of None to the Neutron server for allowed
    address pairs. However, the allowed address pairs extension
    was only allowing an empty list to clear the pairs.

    This patch just converts None to an empty list on allowed
    address pairs to be compatible with the client.

    APIImpact
    Closes-Bug: #1537734
    Change-Id: Iba618b3e07bd3bdc202a9577954d7b97c2a5bf09

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/296505

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/297043

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296505
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=967d003b14e67a92e3469058e16de1301c3c85fa
Submitter: Jenkins
Branch: stable/liberty

commit 967d003b14e67a92e3469058e16de1301c3c85fa
Author: Kevin Benton <email address hidden>
Date: Wed Jan 27 04:34:54 2016 -0800

    Allow address pairs to be cleared with None

    When the neutron client attempts to clear the allowed
    address pairs using the '--action=clear' CLI param, it
    sends a value of None to the Neutron server for allowed
    address pairs. However, the allowed address pairs extension
    was only allowing an empty list to clear the pairs.

    This patch just converts None to an empty list on allowed
    address pairs to be compatible with the client.

    APIImpact
    Closes-Bug: #1537734
    Change-Id: Iba618b3e07bd3bdc202a9577954d7b97c2a5bf09
    (cherry picked from commit 8052c3985325e9067d83496936092ee9334df75b)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dave Walker (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/297043
Reason:
stable/kilo closed for 2015.1.4

This release is now pending its final release and no freeze exception has
been seen for this changeset. Therefore, I am now abandoning this change.

If this is not correct, please urgently raise a thread on openstack-dev.

More details at: https://wiki.openstack.org/wiki/StableBranch

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 7.1.0 release.