We should fix lint for ceph puppet module init manifest

[Stanislaw Bogatkin]

In

https://github.com/openstack/fuel-library/blob/master/deployment/puppet/ceph/manifests/init.pp#L6-L7

there is not defined parameters and it breaks lint check. We should set them to false or undef and add validate() check in class body.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/270955
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2cec77da86f2148a9e256bd46d58aaad2de874ea
Submitter: Jenkins
Branch: master

commit 2cec77da86f2148a9e256bd46d58aaad2de874ea
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 21 20:28:45 2016 +0300

    Increase kernel.pid_max value for ceph-osd nodes

    To meet Ceph requirements and eliminate accidental cascade
    OSD node failures this commit increases kernel.pid_max
    parameter during deploy ceph-osd nodes. Also this commit
    contain some puppet-lint cleanups and validations for this
    module.

    Change-Id: I70a64ff7b85229bf0760be266302d9b32039989a
    Closes-Bug: #1536271
    Closes-Bug: #1537084

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/272019

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/272056

[Maksim Malchuk (mmalchuk)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/272064

[Maksim Malchuk (mmalchuk)]

Changed to high because fix comes together with: https://bugs.launchpad.net/fuel/+bug/1536271

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272064
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=898c29dea9cb5dc0ccd2717158c6e9c238492bc2
Submitter: Jenkins
Branch: stable/6.1

commit 898c29dea9cb5dc0ccd2717158c6e9c238492bc2
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 21 20:28:45 2016 +0300

    Increase kernel.pid_max value for ceph-osd nodes

    To meet Ceph requirements and eliminate accidental cascade
    OSD node failures this commit increases kernel.pid_max
    parameter during deploy ceph-osd nodes. Also this commit
    contain some puppet-lint cleanups and validations for this
    module.

    Change-Id: I70a64ff7b85229bf0760be266302d9b32039989a
    (cherry-picked from commit 2cec77da86f2148a9e256bd46d58aaad2de874ea)
    Closes-Bug: #1536271
    Closes-Bug: #1537084

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272019
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d4dbeb56ca8d8aa161f4491e1cc2cd94988ddce0
Submitter: Jenkins
Branch: stable/8.0

commit d4dbeb56ca8d8aa161f4491e1cc2cd94988ddce0
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 21 20:28:45 2016 +0300

    Increase kernel.pid_max value for ceph-osd nodes

    To meet Ceph requirements and eliminate accidental cascade
    OSD node failures this commit increases kernel.pid_max
    parameter during deploy ceph-osd nodes. Also this commit
    contain some puppet-lint cleanups and validations for this
    module.

    Change-Id: I70a64ff7b85229bf0760be266302d9b32039989a
    (cherry-picked from commit 2cec77da86f2148a9e256bd46d58aaad2de874ea)
    Closes-Bug: #1536271
    Closes-Bug: #1537084

[Mikhail Samoylov (msamoylov)]

Verified by CI job gate-fuel-library-puppet-lint. No need additional checks.

[Ekaterina Shutova (eshutova)]

According to the previous comment:

Verified by CI job gate-fuel-library-puppet-lint. No need additional checks.

No need to verify on 6.1 also. State is changed to Fix Released.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272056
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=92130ddbccf34e81dc14e7c738500884dc13ac37
Submitter: Jenkins
Branch: stable/7.0

commit 92130ddbccf34e81dc14e7c738500884dc13ac37
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 21 20:28:45 2016 +0300

    Increase kernel.pid_max value for ceph-osd nodes

    To meet Ceph requirements and eliminate accidental cascade
    OSD node failures this commit increases kernel.pid_max
    parameter during deploy ceph-osd nodes. Also this commit
    contain some puppet-lint cleanups and validations for this
    module.

    Change-Id: I70a64ff7b85229bf0760be266302d9b32039989a
    (cherry-picked from commit 2cec77da86f2148a9e256bd46d58aaad2de874ea)
    Closes-Bug: #1536271
    Closes-Bug: #1537084