Neutron service was not restarted after executing openstack config

[Ksenia Svechnikova]

ISO: 466

Test: Reconfigure neutron ml2 VLAN range

        Scenario:
            1. Revert snapshot "basic_env_for_reconfiguration"
            2. Upload a new openstack configuration for neutron with new network_vlan_ranges [1]
            3. Get uptime of process "neutron-server" on each controller
            4. Apply a new VLAN range(minimal range) to all nodes
            5. Wait for configuration applying
            6. Check that service "neutron-server" was restarted
            7. Verify ml2 plugin settings
            8. Create new private network
            9. Try to create one more, verify that it is impossible

Test fail on step 6, "neutron-server" was not restarted

[1] http://paste.openstack.org/show/484667/
[2] Failed swarm: https://172.18.160.103/view/8.0_swarm/job/8.0.system_test.ubuntu.services_reconfiguration_thread_1/3/

After investigation it was found that after we repeat the execute one the same env with the same config it would be applied and services will be restarted.

In puppet log for for the test case you can see that service wasn't restart:

[3] http://paste.openstack.org/show/484670/

And this is how the log looks like if new configurations are applied:

[4] http://paste.openstack.org/show/484672/

[Bartosz Kupidura (zynzel)]

Looks like:
DEFAULT/debug already has already value True
quotas/default_quota is already missing from file

So there is no need for restart.

[Sergey Novikov (snovikov)]

After small investigation of this issue the following behaviour was found. If we want to change ml2 vlan range, then we upload config

---
configuration:
 neutron_plugin_ml2:
  ml2_type_vlan/network_vlan_ranges:
    value: "physnet2:1000:1001,physnet1"

and after executing of command:
 # fuel openstack-config --env 1 --execute

just file configuration "/etc/neutron/plugins/ml2/ml2_conf.ini" will be changed but will not applyed. it may be checked creating networks from user with admin role.
# neutron net-create <network_name>
Network has data. There is field "provider:segmentation_id" which must be filled from values if ml2 vlan range from file "/etc/neutron/plugins/ml2/ml2_conf.ini".

For applying this configuration we need to restart service "neutron-server" on each controller node. And I guess this action should be run on step "fuel openstack-config --env 1 --execute".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272034

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272034
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ed519cf3fe47356c9b47d920b98a833c28f497a7
Submitter: Jenkins
Branch: master

commit ed519cf3fe47356c9b47d920b98a833c28f497a7
Author: Bartosz Kupidura <email address hidden>
Date: Mon Jan 25 12:55:52 2016 +0100

    Refresh server-config on neutron_plugin_ml2 change

    After commit ea69a7adb54426a9636c488201d826873bef8648 ml2 configuration
    was moved to server-config from plugins/ml2

    Change-Id: Ib5fe830a362c0a762869c2b68a659a6e944a1d4f
    Closes-Bug: #1537033

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/273402

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/273402
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=885e68887669a66699c933ceaa3f8662a8a02695
Submitter: Jenkins
Branch: stable/8.0

commit 885e68887669a66699c933ceaa3f8662a8a02695
Author: Bartosz Kupidura <email address hidden>
Date: Mon Jan 25 12:55:52 2016 +0100

    Refresh server-config on neutron_plugin_ml2 change

    After commit ea69a7adb54426a9636c488201d826873bef8648 ml2 configuration
    was moved to server-config from plugins/ml2

    Change-Id: Ib5fe830a362c0a762869c2b68a659a6e944a1d4f
    Closes-Bug: #1537033
    (cherry picked from commit ed519cf3fe47356c9b47d920b98a833c28f497a7)

[Ksenia Svechnikova (kdemina)]

Verified by swarm Fuel-8.0 #502

[Ksenia Svechnikova (kdemina)]

Verify on fuel-9.0-mos-388-2016-05-22

Test reconfigure_ml2_vlan_range passed