Fuel for OpenStack

[fuel-agent] Incorrect call of init_http_request

Bug #1536923 reported by Arthur Svechnikov
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Arthur Svechnikov
Fuel for OpenStack 9.0
8.0.x
Fix Released
High
Arthur Svechnikov
Fuel for OpenStack 8.0

Bug Description

[0] is incorrect call for named argument byte_range will lead to exception in [1], because of byte_ranges passed to requests as proxies.

[0] https://github.com/openstack/fuel-agent/blob/master/fuel_agent/utils/utils.py#L225
[1] https://github.com/openstack/fuel-agent/blob/master/fuel_agent/utils/artifact.py#L112-L113

Arthur Svechnikov (asvechnikov)
Changed in fuel:
status: New → Confirmed
assignee: nobody → Arthur Svechnikov (asvechnikov)
importance: Undecided → High
milestone: none → 9.0
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Arthur Svechnikov (asvechnikov) wrote :

Missed gerrit link https://review.openstack.org/#/c/271161/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/271161
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=09cc10177a8fc9bb0fd07f8abac26f339828b8d8
Submitter: Jenkins
Branch: master

commit 09cc10177a8fc9bb0fd07f8abac26f339828b8d8
Author: Artur Svechnikov <email address hidden>
Date: Fri Jan 22 10:18:55 2016 +0300

    Fix arguments' mess with init_http_request

    * add named argument byte_range to HttpUrl
    * fix arguments order for init_http_request

    Change-Id: I6281951f636e8684385ca9f4448d118816aec7b9
    Closes-Bug: #1536923

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/271302

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (stable/8.0)

Reviewed: https://review.openstack.org/271302
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=481ed135de2cb5060cac3795428625befdd1d814
Submitter: Jenkins
Branch: stable/8.0

commit 481ed135de2cb5060cac3795428625befdd1d814
Author: Artur Svechnikov <email address hidden>
Date: Fri Jan 22 10:18:55 2016 +0300

    Fix arguments' mess with init_http_request

    * add named argument byte_range to HttpUrl
    * fix arguments order for init_http_request

    Change-Id: I6281951f636e8684385ca9f4448d118816aec7b9
    Closes-Bug: #1536923
    (cherry picked from commit 09cc10177a8fc9bb0fd07f8abac26f339828b8d8)

Ksenia Svechnikova (kdemina)
tags: added: area-python team-telco
Revision history for this message
Ksenia Svechnikova (kdemina) wrote :

Verify the code with fuel-8.0-502 and 9.0

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.