BPM lock is broken

Bug #1536798 reported by Foss-4
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

OSX 10.11.3 with Mixxx master build from 2016-01-21:
http://downloads.mixxx.org/builds/master/debug/mixxx-2.1.0-alpha-pre-master-git5592-debug-macintel64.dmg

When clicking the lock icon, status is not changed. When re-opening mix, it seems the status has changed, but while mixxx is open the UI is not reflecting the changed status.

Not sure if more UI elements are affected.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hm, can't confirm on latest master HEAD -- OSX 10.11.2
sha: 77c52d45bb3466f5c62ed3860bcd2ec9e5994368

Revision history for this message
Foss-4 (foss-4) wrote :

More detail:

Skin: Deere
Image: http://imgur.com/m4YFguH
Behavior: the locked icon can't be unlocked and vice versa. odd thing is, when restarting mixxx the setting might have changed. so it looks like it's understood the click, but the UI does not instantly reflect status only after re-starting mixxx the status is updated.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

BPM lock can't be enabled either via right-click BPM Options - >Lock BPM or via hte lock icon in the library.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
summary: - lock icon for tempo can't be changed
+ BPM lock is broken
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Uwe, would you mind taking a look? I think this may be related to your recent track work

Changed in mixxx:
assignee: nobody → Uwe Klotz (uklotzde)
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

Tested on Fedora 23 with LateNight and Deere, everything works as expected. Maybe be an OS X only issue?

Changed in mixxx:
assignee: Uwe Klotz (uklotzde) → nobody
RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :
Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Turns out any track metadata change was no longer reflected in the library table (e.g. editing the track with right click -> properties).

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

Ups, I didn't notice that I accidentally cut some signal paths. Thanks for fixing this, RJ!

A small follow-up PR that suppresses 2 redundant signals/invocations:

https://github.com/mixxxdj/mixxx/pull/889

Revision history for this message
Foss-4 (foss-4) wrote :

fix verified. thanks RJ and Uwe for addressing this.

Changed in mixxx:
milestone: none → 2.1.0
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8453

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.