The Bootstrap Developer Theme Preview has some terms that are not being translated

Bug #1536785 reported by Lucas Palm
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Lucas Palm

Bug Description

Under the Developer Dashboard, the Bootstrap Theme Preview has a few strings that are not being translated when they could and should be.

See the attached image for details.

(Note: The image does not contain all occurrences on the page, just a few to get the point across. There definitely is more.)

Revision history for this message
Lucas Palm (lapalm) wrote :
Lucas Palm (lapalm)
Changed in horizon:
assignee: nobody → Lucas Palm (lapalm)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

good catch!

Changed in horizon:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/271453

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/271453
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=76f8e93228d22bbb7dca882b18f4816753eb8015
Submitter: Jenkins
Branch: master

commit 76f8e93228d22bbb7dca882b18f4816753eb8015
Author: Lucas Palm <email address hidden>
Date: Thu Jan 21 16:22:48 2016 -0600

    Fixed a few missed translation strings on Theme preview page

    Under the Developer Dashboard, the Bootstrap Theme Preview has a few
    strings that are not being translated when they could and should be.
    Many of the strings are missing the "translate" directive to enable the
    translation, while others include the directive but are not being translated
    because of other issues. The translation directive seems not to work when
    there is another HTML element tag nested inside the outer element containing
    the translation. As such is the case with the Dropdown elements. The
    solution to this is to use the translate filter in situations where the
    directive will not work.

    This change fixes most of the translation issues on this page.

    Note: The pseudo translation tool was used to determine what strings are
    correctly being translated or not.

    Change-Id: I5aeb9f6212f5ba6a1f4cde0b72cce638937b7138
    Closes-Bug: #1536785

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/290925
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=66be4866439ca9490b8ff1414804715dc0dcb67a
Submitter: Jenkins
Branch: master

commit 66be4866439ca9490b8ff1414804715dc0dcb67a
Author: shu-mutou <email address hidden>
Date: Thu Mar 10 09:38:57 2016 +0900

    Remove unnecessary translate attribute on Theme preview page

    This patch removes unnecessary translate attribute on Theme preview page.
    related to https://review.openstack.org/#/c/271453/

    Change-Id: If1be56e38a50bc52372c68304a46816c86f267a9
    Closes-Bug: #1536785

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0rc1

This issue was fixed in the openstack/horizon 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.