Missed 'volume' from notification definition blocks remaining notifications to be processed

Bug #1536699 reported by Yurii Prokulevych
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Pradeep Kilambi
Liberty
Fix Committed
Undecided
Mehdi Abaakouk

Bug Description

When meter definition is missing 'volume' keyword all other notifications ain't processed.

E.g. having next definition in meters.yaml:
  - name: "image.size"
    event_type:
      - "image.upload"
      - "image.delete"
      - "image.update"
    type: "gauge"
    unit: B
    project_id: $.payload.owner

Leads to next error:
    2016-01-21 09:20:12.363 12161 ERROR stevedore.extension [-] Could not load 'meter': 'volume'
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension [-] 'volume'
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension Traceback (most recent call last):
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/stevedore/extension.py", line 162, in _load_plugins
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension verify_requirements,
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/stevedore/extension.py", line 187, in _load_one_plugin
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension obj = plugin(*invoke_args, **invoke_kwds)
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/ceilometer/meter/notifications.py", line 208, in __init__
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension self.definitions = load_definitions(setup_meters_config())
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/ceilometer/meter/notifications.py", line 188, in load_definitions
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension if (event_def['volume'] != 1 or
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension KeyError: 'volume'
    2016-01-21 09:20:12.365 12161 ERROR stevedore.extension

Regards,
Yurii

Changed in ceilometer:
assignee: nobody → Pradeep Kilambi (pkilambi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272126

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/272126
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=903a0a527cb240cfd9462b7f56d3463db7128993
Submitter: Jenkins
Branch: master

commit 903a0a527cb240cfd9462b7f56d3463db7128993
Author: Pradeep Kilambi <email address hidden>
Date: Mon Jan 25 10:11:43 2016 -0500

    Lookup meter definition fields correctly

    Change-Id: I9db77b9bc196c06c409fcfe252c172230fee4274
    Closes-Bug: #1536699

Changed in ceilometer:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/ceilometer 6.0.0.0b3

This issue was fixed in the openstack/ceilometer 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/311061

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/liberty)

Reviewed: https://review.openstack.org/311061
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=3a1fcaf712a7cdcffafe2ae33bc4c2508bab8a49
Submitter: Jenkins
Branch: stable/liberty

commit 3a1fcaf712a7cdcffafe2ae33bc4c2508bab8a49
Author: Pradeep Kilambi <email address hidden>
Date: Mon Jan 25 10:11:43 2016 -0500

    Lookup meter definition fields correctly

    Change-Id: I9db77b9bc196c06c409fcfe252c172230fee4274
    Closes-Bug: #1536699
    (cherry picked from commit 903a0a527cb240cfd9462b7f56d3463db7128993)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ceilometer 5.0.3

This issue was fixed in the openstack/ceilometer 5.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.