Widelands without sound on win

Bug #1536053 reported by Tino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

Currently the Widelands Windows Installer allows to (de)select both background music and sound effects.
While Widelands runs fine without music files, it does crash when the sound files are missing:

$ ./widelands.exe
Set home directory: C:\Users\user\.widelands
Widelands executable directory: C:\bin\Widelands
Adding directory: C:\bin\Widelands.
selected language: de
Graphics: Try to set Videomode 800x600
Graphics: OpenGL: Version "4.3.0 - Build 10.18.14.4139"
Graphics: OpenGL: Double buffering enabled
Graphics: OpenGL: Max texture size: 16384
**** GRAPHICS REPORT ****
 VIDEO DRIVER windows
 pixel fmt 370546692
 size 800 600
**** END GRAPHICS REPORT ****

Caught exception (of type '10WException') in outermost handler!
The exception said: [C:/projects/widelands/src/sound/sound_handler.cc:254] SoundHandler: Can't load files from sound, not a directory!

This should not happen. Please file a bug report on version master-222(Release).
and remember to specify your operating system.

This does happen although my config lists:
[global]
disable_fx="true"
sound_at_message="false"

Tags: windows
Revision history for this message
SirVer (sirver) wrote :

I can see that making music optional is an argument for total size of download archive, but the same cannot really be made for the sound files. Right now the sound effects accumulate to 2.2MB in total. I would prefer to never make them optional.

Why does the installer allow to not install them in the first place?

Revision history for this message
Tino (tino79) wrote :

I have no idea. The definition of those packages:

  Name: Widelands
  Name: Music;
  Name: Sound;
  Name: Maps;

were already defined when i joined the project. But i agree, the sound files are so small it doesn't make sense.
I will create a branch and remove "Sound" and "Maps" and move the files into the main "Widelands" package.

And let's see, if i can remove the elevated rights usage from the installer...

Changed in widelands:
importance: Undecided → Critical
importance: Critical → Low
assignee: nobody → Tino (tino79)
status: New → In Progress
Tino (tino79)
Changed in widelands:
status: In Progress → Fix Committed
milestone: none → build19-rc1
assignee: Tino (tino79) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.