Not possible to override network_scheme partyally via Hiera deep_merge

[Aleksandr Didenko]

We have a lot of places where we do hiera('network_scheme', {}) instead of hiera_hash():
http://paste.openstack.org/show/484259/

Which makes it simply impossible to use deep_merge possibility to override some parts of network_scheme hash.

We should replace all hiera() function to hiera_hash() in our manifests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/269580

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/269585

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269585
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9d6647d56185cf684712f7d06b1466d97e938434
Submitter: Jenkins
Branch: master

commit 9d6647d56185cf684712f7d06b1466d97e938434
Author: Sergey Vasilenko <email address hidden>
Date: Tue Jan 19 14:50:44 2016 +0300

    Replace usage hiera() to hiera_hash() for all network_scheme lookups

    Lokup by hiera() makes impossible to change network_scheme from plugin tasks.

    Change-Id: I9f034906bb382db13c83e5d320e33800357d72b7
    Closes-bug: #1535679

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269580
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=648fd5444b6adbb0751660f3bea28eb28ae4ddb6
Submitter: Jenkins
Branch: stable/8.0

commit 648fd5444b6adbb0751660f3bea28eb28ae4ddb6
Author: Sergey Vasilenko <email address hidden>
Date: Tue Jan 19 14:50:44 2016 +0300

    Replace usage hiera() to hiera_hash() for all network_scheme lookups

    Lokup by hiera() makes impossible to change network_scheme from plugin tasks.

    Change-Id: I9f034906bb382db13c83e5d320e33800357d72b7
    Closes-bug: #1535679

[Mikhail Samoylov (msamoylov)]

Verified because no problems with cluster deploying and noop test https://ci.fuel-infra.org/job/fuellib_noop_tests/8941/ passed.