Neutron should verify attributes inside a dict

[Bo Chi]

Currently Neutron did not verify the attributes inside a dict, for exp:

If following body is send to neutron server for router-update, no error will show
'{"router": {"external_gateway_info": {"network_id": "b92781fe-2d31-49a6-b648-98d937faf0b8", "wrong": true}}}'
There's a wrong attribute in which is named "wrong"

while the correct body is
'{"router": {"external_gateway_info": {"network_id": "b92781fe-2d31-49a6-b648-98d937faf0b8", "external_fixed_ips": [{"subnet-id": "7ebd8fc9-def1-47f1-97e0-e28c51dc591c"}]}}}'

The solution is to add verify_attributes(data, key_specs) in _validate_dict()

[Armando Migliaccio (armando-migliaccio)]

https://review.openstack.org/#/c/269540/

[Rohan Arora (ra271w)]

Should this bug be closed? After reading through https://review.openstack.org/#/c/269540/, it seems like the function _verify_dict_keys() currently located in neutron-lib/api/validators.py solves the issue described.