Expose the docker build_arg to build.py

Bug #1535617 reported by OpenStack Infra
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla
Expired
Wishlist
Unassigned

Bug Description

https://review.openstack.org/266870
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/kolla" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

commit 7093d37f1825182366939cf64faa477040d29aa2
Author: Jeffrey Zhang <email address hidden>
Date: Fri Jan 8 10:13:39 2016 +0800

    Expose the docker build_arg to build.py

    With this implement, we can add variables at building stage.
    For example, add HTTP_PROXY and NO_PROXY when needed like below.

        build.py --build-args \
            HTTP_PROXY:http://127.0.0.1:8080,NO_PROXY:127.0.0.1

    More info about build_arg, pls check[0]

    [0] https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables-build-arg

    DocImpact

    Implements: bp add-buildargs
    Change-Id: I29ed7f536670fef59d697603dc562a69d90743c9

Tags: doc
Revision history for this message
Hui Kang (huikang27) wrote :

My latest build image command fails due to this commit.

/root/development/kolla/tools/build.py openstack-base
INFO:__main__:Found the docker image folder at /root/development/kolla/docker
INFO:__main__:base:Building
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/root/development/kolla/tools/build.py", line 146, in run
    self.builder(image)
  File "/root/development/kolla/tools/build.py", line 270, in builder
    buildargs=self.conf.build_args):
TypeError: build() got an unexpected keyword argument 'buildargs'

Changed in kolla:
status: New → Confirmed
Revision history for this message
Kuo-tung Kao (jelly) (coding1314) wrote :

@Hui Kang

The issue you hit is that the docker-py version is too old. Try to upgrade to 1.6.0

tags: added: doc
Steven Dake (sdake)
Changed in kolla:
importance: Undecided → Wishlist
milestone: none → newton-1
tags: added: docimpact
removed: doc kolla
Steven Dake (sdake)
Changed in kolla:
milestone: newton-1 → newton-2
Changed in kolla:
milestone: newton-2 → newton-3
tags: added: doc
removed: docimpact
Changed in kolla:
milestone: newton-3 → newton-rc1
Changed in kolla:
milestone: newton-rc1 → occata-1
Changed in kolla:
milestone: ocata-1 → ocata-2
Changed in kolla:
milestone: ocata-2 → ocata-3
Mark Goddard (mgoddard)
Changed in kolla:
status: Confirmed → Incomplete
milestone: ocata-3 → none
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for kolla because there has been no activity for 60 days.]

Changed in kolla:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.