Add a CUP ControlObject

[Daniel Schürmann]

Some controllers like the Reloop Jockey 3 have a dedicated button CUP Cue-Play
* Press, pause at the cue point
* release, play

Traktor has it. Virtual DJ has a config option to replace it wit CUE. It seams to be also usual as a replacement for play.

Currently it has to be implemented in Script
https://github.com/mixxxdj/mixxx/pull/840/files#r50022616

CUP allows a new Mixing style, somehow an inverse stutter play.
If we have this as CO, it can be used from Skin and to be learned on a controller that does not has a dedicated button for it.

This is an ideal starter bug.

The implementation can be done here:
https://github.com/mixxxdj/mixxx/blob/master/src/engine/cuecontrol.cpp#L67

[william lemus (william-lemus)]

Hey,

I'd like to take a look at this. One question I have is whether this would also be useful to also add it as a valid cue mode?

[Daniel Schürmann (daschuer)]

> One question I have is whether this would also be useful to also add it as a valid cue mode?

The Idea was to have the CUP in addition to all cue modes.

Do you wish to have a this as a replacement for play or cue or both as option?

[william lemus (william-lemus)]

Ok makes sense, I meant as option for cue modes. I will add it as another cue mode.

[Sean M. Pappalardo (pegasus-renegadetech)]

It shouldn't be another cue mode, just another ControlObject (so it can be mapped to a physical and/or GUI button) since people may want the Cue+Play ability regardless of what cue mode they've chosen.

[william lemus (william-lemus)]

I should've been clearer. So far I had as a separate cue mode and also a control object that can be mapped. Is there any harm in having the ability to do it both ways?

[Sean M. Pappalardo (pegasus-renegadetech)]

Oh, not at all. I just wanted to make sure it was at least a CO.

[william lemus (william-lemus)]

I have made a pull request:

https://github.com/mixxxdj/mixxx/pull/1001

Please let me know if there is anything I did incorrectly or needs to be changed.

[william lemus (william-lemus)]

Just adding the corrected pull request:

https://github.com/mixxxdj/mixxx/pull/1010

[william lemus (william-lemus)]

When do we go ahead and update the wiki to explain the new cue mode?

[Daniel Schürmann (daschuer)]

Already done in the table:
http://www.mixxx.org/wiki/doku.php/mixxxcontrols?s[]=CUP

The docu update is still missing:
https://github.com/mixxxdj/manual/blob/a3f174f998af673155d5c6273fc643c263a5a44c/source/chapters/user_interface.rst#using-cue-modes

I you like you can issue a PR for it.

[Sébastien BLAISOT (sblaisot)]

I think there is a typo in the wiki, the associated note say "deprecated in Mixxx v2.1.0"
Shouldn't it be "Introduced in Mixxx v2.1.0" ?

[Daniel Schürmann (daschuer)]

Fixed, Thanks!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8449