resources residue for nova server

Bug #1535227 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua

Bug Description

We can find infos such as user/queue/internal_port(Part of https://bugs.launchpad.net/heat/+bug/1533074) residue when delete server if the server has been created successful:

def handle_delete(self):
    if self.resource_id is None:
        return

    return self._delete()

def _delete(self):
    if self.user_data_software_config():
        self._delete_queue()
        self._delete_user()
        self._delete_temp_url()

    # remove internal and external ports
    self._delete_internal_ports()
    self.data_delete('external_ports')
    try:
        self.client().servers.delete(self.resource_id)
    except Exception as e:
        self.client_plugin().ignore_not_found(e)
        return
    return progress.ServerDeleteProgress(self.resource_id)

We should attempt to delete queue/user/temp_url/internal_ports before delete nova server whether or not there is resource_id.

Changed in heat:
importance: Undecided → High
assignee: nobody → huangtianhua (huangtianhua)
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/268956

Changed in heat:
status: New → In Progress
Changed in heat:
milestone: none → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/268956
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2fb51e122c2a647dd44b4befdcaeaa6a9065c3fa
Submitter: Jenkins
Branch: master

commit 2fb51e122c2a647dd44b4befdcaeaa6a9065c3fa
Author: huangtianhua <email address hidden>
Date: Mon Jan 18 17:40:04 2016 +0800

    Attempt to delete internal resources if create server fail

    Attempt to delete queue/user/internal_ports if server hasn't
    been created successful yet, to avoid some infos residue.

    Change-Id: I9d0dababc996cce559a48d4334d835b4f866df3a
    Closes-Bug: #1535227
    Related-Bug: #1533074

Changed in heat:
status: In Progress → Fix Released
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/270566

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b3

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/270566
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=cd3abc743b7de24d41eece0be1d092885430bcd4
Submitter: Jenkins
Branch: stable/liberty

commit cd3abc743b7de24d41eece0be1d092885430bcd4
Author: huangtianhua <email address hidden>
Date: Mon Jan 18 17:40:04 2016 +0800

    Attempt to delete internal resources if create server fail

    Attempt to delete queue/user/internal_ports if server hasn't
    been created successful yet, to avoid some infos residue.

    Change-Id: I9d0dababc996cce559a48d4334d835b4f866df3a
    Closes-Bug: #1535227
    Related-Bug: #1533074
    (cherry picked from commit 2fb51e122c2a647dd44b4befdcaeaa6a9065c3fa)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 5.0.2

This issue was fixed in the openstack/heat 5.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.