Second import from webbrowser/download-manager doesn't auto-start although kicked out of play mode
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Music App |
Fix Released
|
High
|
Andrew Hayzen | ||
Bug Description
First import from webbrowser-app imports into music-app just fine and plays; second import doesn't start playing although it halts play mode, import appears in library.
TEST CASE
Prerequisite: have imported a song, e.g. from last.fm front page already.
1. Open music app, play a song
2. Open webbrowser, navigate to last.fm, tap on a download link to download an mp3
3. "Choose an application" modal pops up, tap "Choose an application"
4. Content-hub screen opens, choose "Music"
5. Download manager icon in header appears
6. "Download Complete" modal appears, tap "Open"
7. Music app opens, modal appears "Waiting for file(s)"
EXPECTED
Currently-playing song stops playing, downloaded song starts playing
ACTUAL
Currently-playing song stops playing, footer reads "Tap to shuffle music"
Related branches
- Jenkins Bot: Approve (continuous-integration)
- Victor Thompson: Approve
-
Diff: 2709 lines (+461/-752)30 files modifiedapp/components/BlurredBackground.qml (+2/-2)
app/components/Flickables/MultiSelectListView.qml (+9/-2)
app/components/HeadState/MultiSelectHeadState.qml (+4/-4)
app/components/Helpers/ContentHubHelper.qml (+11/-8)
app/components/Helpers/UriHandlerHelper.qml (+17/-32)
app/components/Helpers/UserMetricsHelper.qml (+10/-7)
app/components/ListItemActions/AddToPlaylist.qml (+6/-2)
app/components/ListItemActions/AddToQueue.qml (+2/-2)
app/components/MusicToolbar.qml (+37/-23)
app/components/NowPlayingFullView.qml (+57/-17)
app/components/NowPlayingToolbar.qml (+18/-30)
app/components/Player.qml (+0/-240)
app/components/Queue.qml (+18/-20)
app/components/ViewButton/PlayAllButton.qml (+6/-2)
app/components/ViewButton/QueueAllButton.qml (+6/-2)
app/components/ViewButton/ShuffleButton.qml (+6/-2)
app/logic/meta-database.js (+14/-4)
app/logic/playlists.js (+9/-2)
app/music-app.qml (+93/-220)
app/ui/AddToPlaylist.qml (+0/-1)
app/ui/ContentHubExport.qml (+8/-17)
app/ui/NowPlaying.qml (+29/-16)
app/ui/Playlists.qml (+0/-1)
app/ui/Recent.qml (+0/-1)
app/ui/Songs.qml (+2/-3)
debian/changelog (+4/-1)
debian/control (+1/-0)
manifest.json.in (+1/-1)
tests/autopilot/music_app/__init__.py (+30/-11)
tests/autopilot/music_app/tests/test_music.py (+61/-79)
| Andrew Hayzen (ahayzen) wrote | #1 |
| Changed in music-app: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Andrew Hayzen (ahayzen) |
| Changed in music-app: | |
| milestone: | none → ota9 |
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #2 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → Fix Released |
This was an additional issue caused by bug 1534172 as described in comment #3, and has been fixed in the branch :-)
0 - https:/