Unicode string in filtering isn't supported

Bug #1534568 reported by Alexey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
MOS Nova
7.0.x
Fix Released
Medium
Rodion Tikunov
8.0.x
Fix Released
Medium
MOS Nova

Bug Description

It's not possible to use Korean language. This bug is critical for korean users.
It's a customer found bug and the customer uses MOS 7.0.

Horizon and nova patches to accept unicode string in filtering:
(These patches are not yet in openstack upstream, kilo-stable branch.)
https://review.openstack.org/#/c/249101/
https://review.openstack.org/#/c/211850/

description: updated
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :
tags: added: area-horizon area-nova
removed: nova
Dmitry Pyzhov (dpyzhov)
tags: removed: area-horizon
Revision history for this message
Alexey (alexey-odinokov-82) wrote :

Regarding MOS 7.0:
the patches from upstream may be applied without any changes.

We tested that on the customer environment and after that the Korean language works.
The patches we applied and tested, attached to this comment.

tags: added: area-horizon
removed: area-nova
tags: removed: horizon
Revision history for this message
Alexander Gubanov (ogubanov) wrote :

I've verified it on MOS 8.0 (build 470) - works, but found another one https://bugs.launchpad.net/mos/+bug/1538616
Details here http://pastebin.com/yp4TxiA1

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/nova (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Richard Jones <email address hidden>
Review: https://review.fuel-infra.org/16832

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/python-novaclient (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Richard Jones <email address hidden>
Review: https://review.fuel-infra.org/16851

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote :

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: melanie witt <email address hidden>
Review: https://review.fuel-infra.org/17217

Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Release notes:

Compute API now allows filtering of instance names using Unicode characters.

tags: added: release-notes
tags: added: 8.0 release-notes-done
removed: release-notes
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/nova (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/16832
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: b8453bdd8ea569b84e6e3df28bd476fe6a1ddff4
Author: Richard Jones <email address hidden>
Date: Wed Mar 9 11:40:34 2016

Allow filtering using unicode characters

Current code forces the filter arguments to be converted
to a byte string using str() which prevents filtering
using unicode characters. This patch fixes that.
(cherry picked from commit 1c003473353a511142b30ade1aa92f6fb1633e45)

Replace eventlet-based raw socket client with requests

There's no discernable reason why we need to use a raw
eventlet-based client TestWSGIServerWithSSL to confirm that a
wsgi server is listening correctly and returning the expected
response, especially since using eventlet leads to unreliable
i/o on the socket unless there is an explicit yield before
asserting the value of the response.

So requests is used to query the servers and verify the response.
(cherry picked from commit d95b321486f0ff4fd2d3d7f11b656b5b28031d49)

Change-Id: I3abef5da4c2614806011440a4443e869920b4afd
Partial-Bug: #1534568

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/python-novaclient (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/17217
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: c7e5105ef0174c2c309e8100c7d033509da90dd2
Author: melanie witt <email address hidden>
Date: Thu Feb 18 15:55:34 2016

Handle binary userdata files such as gzip

The current code in the servers api assumes only text files will be
provided as userdata. That is, the data is utf-8 encoded before it
is base64 encoded and sent. This breaks for binary userdata files,
(example, gzip files) as they can't be utf-8 encoded.

This change ignores specifically the exceptions that are raised
when utf-8 encoding is attempted on non-text data: AttributeError
and UnicodeDecodeError. These exceptions will be ignored to let
binary files proceed to the base64 encoding step.

Partial-Bug: #1534568
(cherry picked from commit 19d4d35a4e87598f2ec0115753b147552870ceb7)

Change-Id: I3aaab50e6153a2e98002a3ad875de73a1ecd5b80

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote :

Reviewed: https://review.fuel-infra.org/16851
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: 2e1d8f787ca4a6bd6313cedcbf830870e2fa10d9
Author: Richard Jones <email address hidden>
Date: Fri Mar 18 10:03:44 2016

Encode unicode filter arguments for server list

Previously unicode arguments were not encoded so unicode
exceptions were thrown when the arguments were URL encoded.

Conflicts:
 novaclient/tests/unit/v2/test_servers.py

Change-Id: I69a5ac8dcf584ad5b5604caf3c4cb16bb59d3fe3
Partial-Bug: #1534568
(cherry picked from commit 485201453a5d7a9b6b6b81d737edfce7fefb97a2)

Dmitry (dtsapikov)
tags: added: on-verification
Revision history for this message
Dmitry (dtsapikov) wrote :

Verified on 7.0+mu3

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.