SIP prevents renewal when user has any blocking standing penalties
Bug #1534283 reported by
Jeff Godin
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
SIP currently prevents renewal when a user has any blocking standing penalties, even when the block list for a given penalty does not block renewal.
When handling a Renew (29) message, one of the values consulted is the SIP patron object's renew_ok value, which is currently just a copy of their charge_ok value.
This means that anything blocking checkout will also block renewal (via SIP).
Included in the checks for charge_ok is an explicit assumption that standing penalty ids 1 and 2 will block (though their block_list may have been modified), and that any standing penalties with a non-null block_list will block.
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This seems to be working. git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ blake/LP1534283 _SIP_prevents_ renewal_ when_user_ has_any_ blocking_ standing_ penalties
http://